Terminal: Dark mode needs dark titlebar, like Explorer, Settings, Edge, etc.

[Jaykul]

The new (18272) dark-mode scroll bar is nice, but the title bar is still white when the app is focused.
It correctly goes to the "accent color" when it's not active (if you have that on in settings), but goes to white when it looses focus.

Need I say more?

Microsoft Windows [Version 10.0.18272.1000]

[DHowett-MSFT]

@miniksa, unaware that somebody had reported it, just submitted (and merged!) a pull request that fixes this.
Thanks!

[DHowett-MSFT]

A fix for this shipped in 19H1 Insider Build 18312.

[MathiasMagnus]

How can the fix be applied? I am on Windows 1903, I just built the app from the latest tagged version and no matter what the profiles.json says under requestedTheme, may it be "system" or "dark", the title bar is always snow white.

[ysc3839]

@MathiasMagnus This issue is about Console Host. Not Windows Terminal.
Related code: https://github.com/microsoft/terminal/blob/6c7dfd2ce45841d32f3990147506de2f7903485d/src/interactivity/win32/windowtheme.cpp#L1-L119

[Biswa96]

@ysc3839 Is there any code fix for this?

[ysc3839]

@Biswa96 No such issue on 10.0.18362.356.