Terminal: Investigate apparent WinPTY issue with RS5/19H1 builds

Created on 4 Oct 2018 · 19Comments · Source: microsoft/terminal

See https://github.com/Microsoft/vscode/issues/57803

Product-Conhost Resolution-Fix-Available Work-Item

Source

miniksa

👍9

Most helpful comment

Please reconsider your downlevel merge policy, you can't expect people to use Insider builds on production machines and this is a super annoying issue.

Stanzilla on 21 Dec 2018

👍16

All 19 comments

Tracked internally assigned to me as MSFT:19205200

miniksa on 4 Oct 2018

Good news! I found the commit ID that changed the behavior. Yay bisect! Still digging.

miniksa on 5 Oct 2018

👍3

@miniksa did you end up finding a fix?

Tyriar on 11 Oct 2018

I found it was @zadjii-msft's fault and I passed the buck to him. >__>

But he has a fix in PR right now. It's on my queue to read this morning.

miniksa on 11 Oct 2018

🎉6 😄3

Will the fix make it to October 2018 update or do we have to wait for the next big update in 6 months or so?

warpdesign on 25 Oct 2018

@warpdesign The fix won't be in the October 2018 release. It'll be in Insiders builds pretty soon, but if you're afraid of Insiders, then you'll need to wait for the spring release.

zadjii-msft on 25 Oct 2018

👎1

@zadjii-msft ok, thanks for the info. I'm not afraid if insiders but my Surface Book already had lots of problems with the stable releases, don't want to put it to stress :)

I hope the @code team will find a workaround before the fix is released as stable then (see https://github.com/Microsoft/vscode/issues/57803).

warpdesign on 26 Oct 2018

@warpdesign well the workaround is to upgrade to conpty which is blocked on Electron 3 which we're aiming for January currently https://github.com/Microsoft/vscode/issues/52629

Tyriar on 26 Oct 2018

@zadjii-msft what are the chances of shipping important fixes like this in a cumulative update?

Stanzilla on 27 Oct 2018

👍3

@Stanzilla Effectively none. There's very little chance that we ship any console bugfixes downlevel.

zadjii-msft on 30 Oct 2018

👎19 😕16

Effectively none. There's very little chance that we ship any console bugfixes downlevel.

This really needs to change.

doxxx on 17 Dec 2018

👍11

It's still an issue for me. @zadjii-msft mentioned that it will be available to us 3-4 weeks from Oct 15, but it's been long past due https://github.com/Microsoft/vscode/issues/57803#issuecomment-429948320

SYNTAG on 21 Dec 2018

The fix for MSFT: 19205200 reached Windows mainline on October 26, 2018. It should be in Insiders builds that were created on or after that date.

miniksa on 21 Dec 2018

... on or after that date

One such build is 18282. Can you clarify whether you're still seeing this on _RS5 builds_ or on _19H1 builds_?

DHowett-MSFT on 21 Dec 2018

Please reconsider your downlevel merge policy, you can't expect people to use Insider builds on production machines and this is a super annoying issue.

Stanzilla on 21 Dec 2018

👍16

We’d love to! It’s more of a Windows policy than a Console team policy, however, so we’ll keep making noise to the appropriate people.
Thanks!

DHowett on 21 Dec 2018

👍14

Can anyone confirm that this is fixed in WinPTY, in Insiders? Code team has closed their entry on it because they are moving to the new API, but that isn't going to change the other 40 years worth of software that is no longer doing the right thing visually. :-)

I realize that no one is going to want to throw out a visual fix to the release tree on a bug fix, but i'd at least like to know if it'll be fixed for the next windows update (March?)