Terasology: The Great Module Audit and Merge-athon v2.0!

Created on 7 Sep 2019 · 8Comments · Source: MovingBlocks/Terasology

_Edit: More details added for maturity levels, rules for our Merge-athon added - win prizes!_

With GSOC ending and us having merged _a lot_ of fundamental / API breaking things lately I'd like for us to do a round of module testing to catch our breath and make sure all the things are working - or at least compiling and running :-)

The zip I prepared earlier for this September's playtest is http://jenkins.terasology.org/job/DistroOmega/1056/artifact/distros/omega/build/distributions/TerasologyOmega.zip and can be used for testing the before-case as lots of modules will will have broken since, possibly subtly (most/all will compile, some/most will run, a few/some will work fine)

Read on for more details and join us on Discord: https://discord.gg/terasology

Maturity levels in summary:

Compiles - the module builds! Ideally also in Jenkins, not just locally
- To validate Jenkins compare the latest build date at http://jenkins.terasology.org/view/Modules/ with the latest module change date in Git. If there are newer changes ask on Discord for somebody to run it after you've validated that it runs locally (plenty of long term contributors have build access, more can be added if asked for)
Runs - you can run the game with the module active and not crash. Confirm via game logs that the module actually did activate
- Look for a log line like 13:06:22.486 [main] INFO o.t.e.m.loadProcesses.RegisterMods - Activating module: Health:0.1.0-SNAPSHOT to confirm
Works - the main thing the module does appears to be working OK - could be a quick test to verify that you can get and place all blocks or something like that, with any that have obvious UIs able to open
- search [module name] in the game console will be your friend
Polished! - not only does the stuff work, seemingly _all_ of it is in good shape, yay! This'll be fairly easy for smaller modules, but hard for bigger ones (like JoshariasSurvival)
- In modules with StructureTemplate prefabs be sure to validate that they appear to place intact without obvious errors. Look for ways to fix if not, for instance if some of the blocks are in a different module. See the ST readme for more details

I've only included the modules in the stable lineup for now but we might want to add a few more we want to focus attention on. For instance FlexibleMovement has been identified as high potential, but may not even compile just yet.

In some cases (like JS) it'll be hard to determine _which_ module should count as working or not, but ... apply best judgement.

Good First Issue / Hacktoberfest

Testing modules and making small fixes is generally easy. You just need a workspace (see https://github.com/MovingBlocks/Terasology/wiki/Dev-Setup) then groovyw module recurse SomeModule to get all the source for that target module and its dependencies. Run the game, make a new world, make sure the modules are selected. See if everything starts up OK - if so that's two checkboxes already!

Study the module some to figure out what it is actually meant to do so you can look at checkbox 3 and 4. Some modules have wikis, or even test plans. You can use the search ModuleName (with an actual module of course) in the in-game console (tilde or F1) to find all the assets and such in the module to then see what to try out.

For PRs (needed for Hactoberfest) you will actually need to find something broken and then fix it with a PR to the associated module repo :-)

Try to coordinate on our Discord just to avoid duplicate work and to ask questions. If you can't check the boxes directly here or need a whole bunch checked then also ask on Discord. And have fun!

For making a good PR see the template that should populate when you open a PR and https://github.com/MovingBlocks/Terasology/wiki/How-to-Work-on-a-PR-Efficiently

Merge-athon v2.0

As an attempt to hurry along merging any outstanding work before checking the boxes below we will award $100 Amazon gift cards to the top 10 helpful contributors who put in work for testing and merging all the things. Note that this is also an experiment in gamifying contributions so expect the rules to change during the live period of October 5th-19th

Scoring points!

1 for each box checked on The Great Module Audit
??? for each PR merged (varies with complexity and whether you were first to review & test it as well)
??? for each PR reviewed/tested (same)
??? for each new detailed issue covering some outstanding problem (more points for more important)
??? for each issue analyzed and replicated with better details added (varies on complexity + worth of addition)
??? for each _new_ PR that resolves some outstanding issue (not really meant for brand new functionality or anything other than code bugs)

We'll keep a private leaderboard and may extend the contest (after guaranteeing the top 10 as of October 19th), increase the number of gift cards, or add value to those going to particularly helpful contributors :-)

To get your points please ask on Discord and link to your work. Please be patient as it may be a little while before everything gets processed and responded to, but we'll get it!

The list!

AdditionalFruits

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

AdditionalItemPipes

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AdditionalRails

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AdditionalVegetables

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AdditionalWorlds

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AdvancedRails

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AdventureAssets

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Alchemy

[ ] Compiles - nope!
[ ] Runs
[ ] Works
[ ] Polished!

AlchemyPlantGenerator

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AlterationEffects

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Anatomy

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AnotherWorld

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

AnotherWorldPlants

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Apiculture

[ ] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

BasicCrafting

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Behaviors

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

BlockDetector

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

BlockNetwork

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

BlockPicker

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Books

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Breathing

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

CakeLie

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Caves

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

ChangingBlocks

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

CheatsForAll

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

ChiselBlocks

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

ChrisVolume1OST

[x] Compiles
[x] Runs
[x] Works
[x] Polished!

ChrisVolume2OST

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Cities

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

ClimateConditions

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Climbables

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

CombatSystem

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

CommonWorld

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Compass

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

ComputerMonitors

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Cooking

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

CopperAndBronze

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

CoreAssets

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

CoreBlocks

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

CustomOreGen

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

DamagingBlocks

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Dialogs

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Durability

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

DynamicCities

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

Economy

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

EdibleFlora

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

EdibleSubstance

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Equipment

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

EquipmentSmithing

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

EventualSkills

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Exoplanet

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

Fences

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

FlexiblePathfinding

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

FlowingLiquids

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Fluid

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

FluidComputerIntegration

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

FunnyBlocks

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Genome

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

GooeyDefence

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

GooeysQuests

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

GooKeeper

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

GrowingFlora

[ ] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Health

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

HjerlHede

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

HumanoidCharacters

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Hunger

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Inferno

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

InGameHelp

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

InGameHelpAPI

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

Inventory

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

IRLCorp

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

ItemPipes

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

ItemRendering

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

JoshariasSurvival

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

Journal

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Kallisti

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

KComputers

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

Lakes

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

LegacyMusic

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

LightAndShadow

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

LightAndShadowResources

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Lost

[ ] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Machines

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Malicious

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

ManualLabor

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

ManualLaborEventualSkills

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

MarcinScIncubator

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

MarkovChains

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

MasterOfOreon

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

MawGooey

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Maze

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

MedievalCities

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

MetalRenegades

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Minerals

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Minesweeper

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Minimap

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

MobileBlocks

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

ModularComputers

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

ModuleTestingEnvironment

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

MoreLights

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

MultiBlock

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

MusicDirector

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

NameGenerator

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

NeoTTA

[ ] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

OreGeneration

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Oreons

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Pathfinding

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

PhysicalStats

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

PlantPack

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

PolyWorld

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Portals

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

PotentialEnergyDevices

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Potions

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Projectile

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

QuestExamples

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Rails

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Sample

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Scenario

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Seasons

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

SegmentedPaths

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Sensors

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

ShatteredPlanes

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Signalling

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

SimpleFarming

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

SimpleLiquids (note: moved to our org archive, may need to reflect here and elsewhere)

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Smithing

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Soils

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

SoundyGenetics

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Spawning

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

StaticCities

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

StoneCrafting

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

StructuralResources

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

StructureTemplates

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

SubstanceMatters

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

SurfaceFacets

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Tasks

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Thirst

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

ThroughoutTheAges

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

TutorialAssetSystem

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

TutorialBehaviors

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

TutorialDynamicCities

[ ] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

TutorialNui

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

TutorialSectors

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

TutorialWorldGeneration

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Valentines

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WeatherManager

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WildAnimals

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WildAnimalsGenome

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WildAnimalsMadness

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WoodAndStone

[ ] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WoodAndStoneCraftingJournal

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

WoodCrafting

[x] Compiles
[ ] Runs
[ ] Works
[ ] Polished!

Workstation

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

WorkstationCrafting

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

WorkstationInGameHelp

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

WorldlyTooltip

[x] Compiles
[x] Runs
[x] Works
[ ] Polished!

WorldlyTooltipAPI

[x] Compiles
[x] Runs
[ ] Works
[ ] Polished!

Content GCI Good First Issue Hacktoberfest Research

Source

Cervator

Most helpful comment

All of the pull requests for the CoreAssets & CoreBlocks refactor have been merged!

Qwertygiy on 18 Oct 2019

🎉2

All 8 comments

Here's a list of compatibility PRs for #3704 in the various modules. They should all be ready for a quick review and merge by anyone who would like to give it a shot:

Qwertygiy on 29 Sep 2019

👍2

What could be the creteria of making a nice pull request that best your needs, could it be fixing bug or any other. we would like to give us more light about terasology

sherrif10 on 1 Oct 2019

Hello! My name is Monique and I want to contribute. How could I proceed? Have a nice day!

monique1087 on 6 Oct 2019

Hi @sherrif10 and @monique1087 - I've just updated the original description with some more details, including a parallel contest we're running with actual giftcard prizes now! :-)

Dig around in our project documentation for more, like starting with https://github.com/MovingBlocks/Terasology/wiki/Dev-Setup and hop on our Discord to ask further questions if needed! https://discord.gg/terasology

Cervator on 7 Oct 2019

Thanks @monique1087 , Contributing is very easy , just fork the repo then
clone it into your local machine, create a branch and make commit changes
then push them to the github, remember your original repository should be
updated for pull request to be successful. Any help please am here to help
you thanks. Am sorry for late reply

On Sun, Oct 6, 2019 at 8:55 AM monique1087 notifications@github.com wrote:

Hello! My name is Monique and I want to contribute. How could I proceed?
Have a nice day!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MovingBlocks/Terasology/issues/3737?email_source=notifications&email_token=ALOKS6BLU5DDBHYRCQ7X5PLQNIC5NA5CNFSM4IURDU32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAONJEI#issuecomment-538760337,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALOKS6HJY4WQSG2VRVB2FWTQNIC5NANCNFSM4IURDU3Q
.

sherrif10 on 7 Oct 2019

Ok! Thank you all very much!

monique1087 on 9 Oct 2019

All of the pull requests for the CoreAssets & CoreBlocks refactor have been merged!

Qwertygiy on 18 Oct 2019

🎉2

Update: All modules have been built (or fail to build) in the new Jenkins' mega module build job. I've checked off most of them with a few remaining that need a closer look. They're either failing for legitimate compile issues (like Alchemy seemingly is) or possibly need some more poking in Jenkins.

The failing modules of interest as of right now are:

Alchemy
Apiculture
GrowingFlora
Lost
NeoTTA
RomanCities
TutorialDynamicCities
TutorialGroups
WoodAndStone
WorldPortals

Cervator on 3 Nov 2019

Was this page helpful?

0 / 5 - 0 ratings

Related issues

Diagonal artifacts on a Radeon R9 Fury with similar modern system stats

Cervator · 4Comments

Add PRONE Mode

nihal111 · 4Comments

Lens Flares Node

emanuele3d · 3Comments

Bush growth / block family issue seen with fruit bushes in JS in multiplayer

Cervator · 3Comments

Opening the BT editor with F5 in multiplayer after spawning a few deer then trying to open the drop-down meant to hold BT entities crashes the game

Cervator · 6Comments