Terasology: Let game console "redial" ignore duplicated repeated commands

[Cervator]

Current situation: if you enter give stone once then give dirt 10 times in the game console (F1 or grave / ~ key key) you need to up arrow 11 times before you'll get give stone from the console history again.

Desired situation: console history ignores successive identical commands (and also always ignores entirely empty commands)

See: ConsoleImpl.java for some of the involved code.

Should be easy!

[bhi5hmaraj]

Hi , I'm Bhishmaraj a Computer Science Undergrad from India . I'm new to the open source community and I'm interested in fixing this bug . I have already cloned the project from GitHub and built it using gradlew and tried playing it . Can you please help get getting started to fix this bug.

[ThompsonTyler]

You will probably want to check out UICommandEntry.java for the "redialing" and then setup the command history to work as desired.

[bhi5hmaraj]

Thanks , I'll try to fix this

[emanuele3d]

@bhi5hmaraj: it appears vampcat has already tackled this issue successfully? (PR merging notwithstanding)

If so @vampcat, please be aware of other people who already offered to work on issues. We are a community and one of the things we try to do is to be considerate with each other.

[vampcat]

Ah, I'm sorry. Cervator offered up the task on IRC as soon as it was added, and I completed the task at that time. I thought I commited too, but apparently GitHub Desktop thought otherwise.. so the late commit. bhi4hmaraj had not started at that time. Either way, I'll make a comment next time before starting.

[Cervator]

Yeah I probably caused this one, as I realized moments after I advertised the new issue on IRC with several students active + it being the very first issue listed while other students are surfing our issue tracker ... :D

But yep if coding starts please note on the issue :-)

[vampcat]

Aye aye cap'n. And again, sorry for any trouble it caused.

[vampcat]

Can someone mark this as closed?
(Fixed with https://github.com/MovingBlocks/Terasology/pull/2814)

[Cervator]

Whoops, missed this one. Thanks @vampcat!

Closing as complete