As title.
Please consider to add an official AdoptOpenJDK GitHub Action.
Thanks
Davide
https://github.com/AdoptOpenJDK/build-jdk
The action building the jdk according to the steps in Build jdk natively on your system part on README.md, which is different from the repo's workflow. The yaml file use ./build-farm/make-adopt-build-farm.sh.
@sblantipodi what's your use case for this action?
thanks for the answer @sophia-guo
love AdoptOpenJDK, your "free" support is incredible.
I would like to have a simple action to setup AdoptOpenJDK on my workflow:
- name: Set up JDK 14
uses: actions/setup-java@v1
with:
java-version: '14.x.x'
https://github.com/marketplace/actions/setup-java-jdk
I will look in your link and how to use it, thanks!
For setup-java you can use https://github.com/AdoptOpenJDK/install-jdk
WOW! thank you for the help!
closing the issue, thanks!
just last question @sophia-guo if I can.
why this action is not present here?
https://github.com/marketplace?query=adopt
@karianna may have answer?
We had not yet put these github actions in the marketplace as they are still being enhanced/improved, but certainly the plan was to likely do so at some point, including the run-aqa action that enables developers to run tests against a freshly built or freshly installed binary. It will need to be discussed and be agreed upon by the TSC. I can add it to our next meeting's agenda.
hi @sophia-guo but does the installjdk action works on macos?
- name: Set up AdoptOpenJDK 15
uses: AdoptOpenJDK/install-jdk@v1
with:
version: '15'
architecture: x64
using this but when I run
java -version
I see the JDK 1.8 version
should that action set the JDK15 as the default JDK?
Answering ahead of @sophia-guo seeing its the start of the weekend:
install-jdk does support macos (https://github.com/AdoptOpenJDK/install-jdk/blob/master/src/installer.ts#L11)
install-jdk currently requires version to be set (so has no default)
https://github.com/AdoptOpenJDK/install-jdk/blob/master/src/install-jdk.ts#L6.
Requiring it removes the continued need to keep updating with every new release.
This can now be closed, based on TSC discussion, we'll add build-jdk and run-aqa to the actions marketplace.
Most helpful comment
We had not yet put these github actions in the marketplace as they are still being enhanced/improved, but certainly the plan was to likely do so at some point, including the run-aqa action that enables developers to run tests against a freshly built or freshly installed binary. It will need to be discussed and be agreed upon by the TSC. I can add it to our next meeting's agenda.