Teammates: Instructor: edit student data: fix typo in error message for team/section name

[LowWeiLin]

...All a team name must ...

Should either be: A team name must ...
or: All team names must ...

[junhaoyap]

Fixing this can cause "typos" in other error messages such as ->

because the field validator messages concatenates strings and uses it for all name field validations.

[damithc]

@YongJieYongJie this issue must be fixed now, am I right?

[YongJieYongJie]

@damithc Now that FieldValidator is slightly tidier, we can rephrase the error message to avoid such problems, something like:

"|" is not acceptable to TEAMMATES as a/an team name because it starts with a non-alphanumeric character. A valid team name must start with an alphanumeric character, and cannot contain any vertical bar (|) or percent sign (%).

Alternatively, we can have a more drastic rephrasing:

"|" is an invalid value for the field [team name]. A valid [team name] must...

[damithc]

Sure, we should improve the error message if we can.

[amarlearning]

Looks like the issue is fixed by now! _[screenshot]_

This looks good but as suggested by @LowWeiLin we can change it to " All team names must "

[amarlearning]

@damithc Is this issue still open?

[damithc]

Yes. I think it is easier to phrase it as A team name must start with etc.

[amarlearning]

working on this

[amarlearning]

@damithc Looked in the FieldValidator.java file and found out that " _Every field which contains (%) and (|) as input will be considered as invalid input_ ".

The general error message for such input is All ${fieldName} must start with an alphanumeric character, and cannot contain any vertical bar (|) or percent sign (%).

Solution:

1. If I change All -> A, it will then be applied to all input field.
2. Rephrase the invalid message just for the team name. (A team name must start with an alphanumeric character, and cannot contain any vertical bar (|) or percent sign (%).)

Any suggestions?

[damithc]

Option 1 is better, as long as it works for all fields.

[LiHaoTan]

@damithc can we change All to The instead because some of the field names have vowel sounds.
Example:

"Institute|" is not acceptable to TEAMMATES as a/an institute name because it contains invalid characters. The institute name must start with an alphanumeric character, and cannot contain any vertical bar (|) or percent sign (%).

[whipermr5]

@LiHaoTan The doesn't sound right; maybe we can use A/an like in the previous sentence (though it's ugly)? Ideally we should do vowel sound detection.