Teammates: Instructor: search students: add a confirmation dialog for the "delete" button

[ryancyq]

Currently, there isn't any test checking for the confirmation dialog of "delete" button.

[damithc]

In fact, there is no confirmation for the delete button. :-p

[amarlearning]

@damithc Is think this issue should be closed because I just checked there is a confirmation modal for the delete button. _[screenshot]_

[damithc]

Is think this issue should be closed because I just checked there is a confirmation modal for the delete button.

@amarleraning
Yes, there seems to be a confirmation dialog (my bad), but this issue is about adding tests for it. Check if your UI tests cover the said modal dialog.

[amarlearning]

@damithc I think then the title of this issue should be changed :smile:

[damithc]

@damithc I think then the title of this issue should be changed

You are right. Done. 👍

[amarlearning]

Check if your UI tests cover the said modal dialog.

@damithc Yes, we do have a test for the delete button.

Both viewPage.clickDeleteAndCancel(courseId, studentName) and viewPage.clickDeleteAndConfirm(courseId, studentName) are covered. :+1:

[amarlearning]

The issue still open? :sweat_smile:

[whipermr5]

@amarlearning The instructor search page delete does not have a confirmation modal. You were looking at the instructor student list page.

[joanneong]

I will try working on this issue.