Teammates: Instructor: Feedback Session: Mark mandatory fields for creating and editing session

[mg14777]

Description of feature/enhancement
Mark mandatory fields using * or some other mechanism when user creates a new feedback session or edits existing feedback session.

Currently, user is only notified of mandatory fields on form submission

It will be even better if these errors are attached to the fields rather being listed at one place.
Example:

[sukanta-27]

We can also use HTML 5 form validation here. Making the mandatory fields as required?

[mg14777]

We can also use HTML 5 form validation here

One slight issue we need to keep in mind is that different browsers tend to have different behaviour when displaying the error. We might need some additional CSS to ensure consistency.

[sukanta-27]

We might need some additional CSS to ensure consistency.

Yes, we can do that, but as this is a browser specific behaviour, do we need to deal with this? I mean, if our main concern is that, the user doesn't leave a important field blank, then isn't adding additional CSS an overkill? But yes, if we do go this way, there are many places where we can use the CSS for better UX.

[mg14777]

@sukanta-27 Yeah I mainly meant from a UX perspective. It's not core to the issue at hand.

[damithc]

We try to avoid/minimize front-end validation (in spite of the UX cost) because we still have to do back-end validation (reason: front-end validation can be bypassed) and then we end up duplicating the validation logic, once in JS and once in Java.

[ah91086]

Given what damithc said, would the best course of action be to simply edit the corresponding .tag file to mark the mandatory fields with a star since front-end validation isn't an option?

[LiHaoTan]

Minimal frontend validation can still be used with HTML form validation but more important validation checks should only likely exist in the backend.

There are certainly UX issues like what @mg14777 mentioned, including accessibility. However, these are things that we do not have to resolve on our own, for example, Bootstrap 4 supports HTML form validation.

[gildas15]

PLease can you assign this issue to me. I want to work on it