Teammates: *.jsp: change to 2-space indentation

Created on 22 May 2017  Â·  8Comments  Â·  Source: TEAMMATES/teammates

Refactor all *.jsp pages to use 2-space indentation instead of 4.

a-CodeQuality c.Epic help wanted p.Medium

Most helpful comment

Just a heads-up, this is quite a dirty work (but somebody has to do it), and it's not as easy as writing a script to change 4 spaces to 2 spaces because of some custom indentations applied in the past. It could be the starting step, but needs manual re-tracing once again to make sure nothing looks weird.

This should be broken into few PRs, otherwise the changeset could easily reach 5 digits.

All 8 comments

@damithc taking this one

Just a heads-up, this is quite a dirty work (but somebody has to do it), and it's not as easy as writing a script to change 4 spaces to 2 spaces because of some custom indentations applied in the past. It could be the starting step, but needs manual re-tracing once again to make sure nothing looks weird.

This should be broken into few PRs, otherwise the changeset could easily reach 5 digits.

Effort tracker, to be updated as each PR is merged:

| PR | Effort |
| - | - |
| #7535 | 2 |
| #7623 | 4 |
| #7662 | 2 |
| #7762 | 2 |
| #7705 | 2 |
| #7772 | 2 |
| #7773 | 2 |
| #7814 | 2 |
| #7802 | 2 |
| #7929 | 2 |
| #7952 | 2 |
| #7951 | 2 |
| #7956 | 2 |
| #7970 | 2 |
| #7971 | 2 |
| #7967 | 2 |
| #7982 | 2 |
| #8086 | 2 |

@wkurniawan07 I think all files are covered now ?

@sujeet14108 actually, there are some files that you missed, but you have done enough.

@damithc can i take this issue?

@dipzzzz This issue has been taken. Feel free to take any of the first timer issues you commented on that have no currently open PRs (but you may only choose one).

OK.Thank you.

On 6 Oct 2017 11:45 a.m., "John Yong" notifications@github.com wrote:

@dipzzzz https://github.com/dipzzzz Feel free to take any of the first
timer issues you commented on that have no currently open PRs (but you may
only choose one).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TEAMMATES/teammates/issues/7352#issuecomment-334667971,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad78NV-9atogF-bms5-dM2bELVLfgXgfks5spcWNgaJpZM4NiPbZ
.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

whipermr5 picture whipermr5  Â·  3Comments

xpdavid picture xpdavid  Â·  3Comments

wkurniawan07 picture wkurniawan07  Â·  4Comments

amarlearning picture amarlearning  Â·  4Comments

whipermr5 picture whipermr5  Â·  4Comments