Teammates: Instructor: feedback results: provide copy instructions for Mac OS

[chowyb]

In instructorFeedbackResultsPage, when using the "click here" text to view the results in a table, instructions are provided to copy and paste the table into an Excel workbook.

However, Mac systems use Command + C and Command + V instead, which could be added to the instructions.

[arjunsuri]

hey I would like to take this issue

[arjunsuri]

Is this issue still open?

[ncbaihly]

It seems that the previous PR for this issue got closed and wasn't accepted. I'm going to start working on this as my first time PR.

[ncbaihly]

So I I made the changes(see screenshot), however they break some of the UI tests because the page doesn't match what the tests are expecting.

I'm going to go ahead and change the test files to match the changes. If everything works out I'll make a pull request soon.

EDIT:
The copy paste instructions also occurs on the InstructorCourseDetailsPage, which is the only other page I've found so far that has these instructions. Going to change that as well.

[ncbaihly]

So I'm still working on fixing the UI tests, one issue I've run up against is that even though I checked the HTML files that are being compared with the pages from my local instance and amended them to match the instruction changes, I'm still failing tests.

The reason seems to be an extra newline, but when I check the corresponding HTML file that's being compared with what the site displays, there is no newline at the position that failed. I tried clearing the browser cache, but that did not do anything.

Is there somewhere else where things might be cached that could affect the tests? Or is the HTML file transformed at all before being compared? Looking at the verifyHtml functions it doesn't seem to be, but I wonder if I might be missing something.

[LiHaoTan]

@ncbaihly are you using GodMode to update the HTML files? If not, you might want to give that a try, in fact, you should use that anyway.

I apologize I can't provide more details about how GodMode works because I don't recall them, but hopefully, someone else would address your question. There are some intricacies involved, and of course alternatively, you can always take a look at how HtmlHelper works.

Is there somewhere else where things might be cached that could affect the tests? Or is the HTML file transformed at all before being compared? Looking at the verifyHtml functions it doesn't seem to be, but I wonder if I might be missing something.

So yes, both the source and actual HTML are transformed before being compared. However, there are no other files being cached that could affect the tests, everything you see should be in the corresponding test (and to be clear, you will see the file in version control, not hidden in some cache in some other folder).

[ncbaihly]

@LiHaoTan Oh I am not, I must have missed that when I was reading the starter's guide. That sounds like it well help with my issue, Thanks!

[LiHaoTan]

@ncbaihly I just went to revisit the documentation and I think we weren't very clear about when to utilize GodMode. If you have any suggestions on how to improve the documentation do let us know :)

[ncbaihly]

@LiHaoTan I went back and took a look, maybe this would be more relevant posted somewhere else, but I think it may be a good idea to add a section about GodMode to the Development Workflow(process.md) document, which is what I've used a lot in referencing to try and make sure I'm following the correct process.

Maybe add a little bit about it and a link to its documentation page in Step 3, subpart 3. I think adding in a bit about how you might need to update stuff with GodMode in the "Before submitting your work for review, here are some things to check (non-exhaustive):" section might be helpful.

[LiHaoTan]

@ncbaihly Thanks a lot for your feedback and I see that you have created an issue to address this. Many thanks!