Tdesktop: [Bug] No context menu on titlebar

[maxoku]

Steps to reproduce

Click with right mouse button on titlebar.

Expected behaviour

A context menu appears.

Actual behaviour

Nothing happens.

Configuration

Operating system: Windows 8.1
Version of Telegram Desktop: 1.9.6
Used theme: Day

[kirsan31]

Confirmed on Windows 7 and tdesktop 1.9.4. On 1.8.15 work fine.

[kirsan31]

WM_SYSCOMMAND, SC_MOUSEMENU correctly sending on WM_NCRBUTTONUP. But after that WM_SYSCOMMAND not firing, so we never show menu.

https://github.com/telegramdesktop/tdesktop/blob/b0c2ed839d43309ded0cc9a06adfd9bdf5766c17/Telegram/SourceFiles/platform/win/windows_event_filter.cpp#L228-L238

I think this event is filtered somehow, but cant't find where...
cc @john-preston

Still here on 1.9.7.

[kirsan31]

I checked all filters down to QEventDispatcherWin32::processEvents and still find nothing :( The simple solution is to move menu logic from WM_SYSCOMMAND && SC_MOUSEMENU to WM_NCRBUTTONUP directly, but @john-preston may think differently...

[john-preston]

@kirsan31 Why do you need this menu at all? 🤔

[23rd]

Just to remind that there is always Alt+Space as a workaround.

[kirsan31]

@kirsan31 Why do you need this menu at all?

Technically yes, due to not native title bar, this menu is not needed. And on native bar, it's needed only by left click on top left corner :smile:

[Aokromes]

i suppose https://github.com/telegramdesktop/tdesktop/issues/2958

[kirsan31]

i suppose #2958

No, there are code that shows this menu manually. But it's broken somehow from 1.9.x ...