Tdesktop: Typing ":o" doesn't bing the smiley anymore in 1.2.20 alpha

[Geobert]

Steps to reproduce

1. type ":o " (note the space)
2. enter

Expected behaviour

Should get an emoji

Actual behaviour

we got the text ":o"

Configuration

Operating system:
Windows
Version of Telegram Desktop:
1.2.20 alpha
Used theme:
custom theme

This is because:
https://github.com/telegramdesktop/tdesktop/blob/4b763a76df514c6f98bc588b66b8df070ec66d85/Telegram/SourceFiles/codegen/emoji/data.cpp#L60

why the need of typing ":ok" without space after ":" ?

after the emoji suggestion panel, I already had to add an extra space to get the correct emoji (I got :o: emoji instead).

Since 1.2.20, I can't type the ":o" emoji at all.

[john-preston]

@Geobert :ok is a start of an emoji replacement. If you replace :o instantly you can't type :ok if you want :ok: or :ok_hand:

[Geobert]

I see, can we have ":o " (with trailing space) as a workaround then? As we had anyway to add the space to avoid :o: witch was automatically selected in the suggestion box

[stek29]

@john-preston Indeed, what about requiring additional whitespace character for non-:: emoji replacements?
The only issue I can see is handling them in the message end.

[john-preston]

@stek29 You want only to return :o or to require space in some other replaces as well?

[stek29]

@john-preston I think that requiring whitespace makes sense for other replacements too

[Geobert]

Fixed in 1.2.21 alpha! Thanks!

[stek29]

@john-preston Is :o in the end of message not considered as an issue?

[john-preston]

@stek29 I don't think it is. You can press space and get the emoji.

[Geobert]

I confirm it works at the end of a message :)