Tasmota: Longitude & Latitude failing to set properly for values between 0 & -1

Created on 3 Mar 2019 · 8Comments · Source: arendst/Tasmota

Longitude Latitude failing to set properly for values between 0 & -1.
Working for number below -1

14:11:54 RSL: STATUS2 = {"StatusFWR":{"Version":"6.4.1(sonoff)","BuildDateTime":"2018-12-24T14:41:00","Boot":31,"Core":"2_4_2","SDK":"2.2.1(cfd48f3)"}}

Failing above -1

14:25:39 CMD: latitude -0.2
14:25:39 RSL: Received Topic /latitude, Data Size 4, Data -0.2
14:25:39 RSL: Group 0, Index 1, Command LATITUDE, Data -0.2
14:25:39 RSL: RESULT = {"Latitude":"0.200000"}

14:25:59 CMD: Longitude -0.2
14:25:59 RSL: Received Topic /Longitude, Data Size 4, Data -0.2
14:25:59 RSL: Group 0, Index 1, Command LONGITUDE, Data -0.2
14:25:59 RSL: RESULT = {"Longitude":"0.200000"}

Working below -1

14:25:49 CMD: latitude -1.2
14:25:49 RSL: Received Topic /latitude, Data Size 4, Data -1.2
14:25:49 RSL: Group 0, Index 1, Command LATITUDE, Data -1.2
14:25:49 RSL: RESULT = {"Latitude":"-1.200000"}

14:26:04 CMD: Longitude -1.2
14:26:04 RSL: Received Topic /Longitude, Data Size 4, Data -1.2
14:26:04 RSL: Group 0, Index 1, Command LONGITUDE, Data -1.2
14:26:04 RSL: RESULT = {"Longitude":"-1.200000"}

awaiting feedback bug fixed

Source

ggaavv

All 8 comments

True, but thats more or less a theoretical bug - these positions (0 to -0.999) are @ Atlantic ocean 700 km next to an island in the middle of nowhere

curzon01 on 5 Mar 2019

👎1

A longitude band and a latitude band, rather than a single tiny point. The worst case is about a 15 minute sunset/sunrise error. The UK sits right in the middle of the band. My location is latitude -0.89 which got taken as 0.89 so almost worst case.

ggaavv on 5 Mar 2019

👍1

this solves the issue

// better char to double
double CharToDouble(char str) {
// simple ascii to double, because atof or strtod are too large
char strbuf[24];
strlcpy(strbuf, str, sizeof(strbuf));
char *pt=strbuf;
double left,right;
signed char sign=1;
if (pt=='-') sign=-1;
if (pt=='-' || *pt=='+') pt++;
if (pt=='.') {
// .xxx notation
left=0;
goto gright;
}
// get left part
left = atoi(pt);
// skip number
while (pt>='0' && *pt<='9') pt++;
if (pt=='.') {
// decimal part
gright:
pt++;
right = atoi(pt);
while (*pt>='0' && *pt<='9') {
pt++;
right /= 10.0;
}
} else {
right=0;
}
double result = (left + right);
if (sign>=0) return result;
else return -result;
}