Tasks: Don't show subscribed ical calendars in the calendar list?

[szaimen]

I have created this issue so that we can discuss whether subscribed ical calendars should be shown in the calendar list or not. link to the inital comment: https://github.com/nextcloud/tasks/issues/908#issuecomment-596215513
IMO, they shouldn't get shown like it was before on 0.11.3 - at least if no task is existant in there.

[raimund-schluessler]

I am a bit surprised that subscribed calendars didn't show up with 0.11.x already. I don't have any, so I cannot tell (I could test it though 🙈).

However, every calendar which has the VTODO component set, will show up. I think this is the expected behaviour since a subscribed calendar with VTODO can contain tasks which are wanted to be shown.

[raimund-schluessler]

The correct solution would be that a subscribed calendar without tasks should not contain the VTODO component.

What we can do on our side probably is https://github.com/nextcloud/tasks/issues/84.

[szaimen]

The correct solution would be that a subscribed calendar without tasks should not contain the VTODO component.

Yes, but the subscribed calendar seems to have it and I will not be able to delete it.

What we can do on our side probably is #84.

Beeing able to hide such calendars sound like a good idea 👍

---

I imagine this as an option here where you can click on "hide calendar"

---

If there are hidden calendars, an additional field could be shown below "add list" where you could click on "show all lists" or "show hidden lists" and could make them visible again by clicking on that. if clicked again they could become hidden again.

[raimund-schluessler]

Then let's merge this issue with #84.

[ltGuillaume]

I'm having the same issue (all my subscribed calendars from https://fixtur.es) are shown in Tasks, _but_ they do NOT have VTODO specified in the table oc_calendars under components. I searched the .ics file for any todo references: nothing. Still, they turn up in Tasks.

So where do you get the info from that they even support VTODO?

[raimund-schluessler]

@ltGuillaume would it be possible that you share the complete link of one of the subscriptions (if you want by email) so I can try to debug this?

[ltGuillaume]

@raimund-schluessler https://ics.fixtur.es/v2/league/formula-1.ics

[raimund-schluessler]

@ltGuillaume Subscribed calendars shouldn't be listed in oc_calendars afaik, at least they do not show up there on my instance. They are listed in oc_calendarsubscriptions for me and this table doesn't have a components column. Are you sure they are really in this table?

Also, the server returns ["VEVENT", "VTODO"] as components of the subscribed calendars. So I guess this could be server issue!?

@georgehrke Is there a way to figure out if a subscribed calendar has VTODOS?

[ltGuillaume]

@raimund-schluessler You are totally right, very sorry. The subscribed calendars are indeed listed only in oc_calendarsubscriptions inside the database. However, these calendars are also listed in Tasks somehow. When I subscribe to a new calendar, it's also added to Tasks.

Also, the server returns ["VEVENT", "VTODO"] as components of the subscribed calendars.

Which server do you mean, fixtur.es? How can I check that?

[raimund-schluessler]

Which server do you mean, fixtur.es? How can I check that?

Nextcloud server, it returns all subscribed calendars and shows them as also containing VTODOs. Don't know where Nextcloud gets this information from.

[ltGuillaume]

@raimund-schluessler Then I would say I would get the same issues with DAVx5+ICSx5, together with OpenTasks on Android, but I don't: DAVx5 only shows VTODO for two of my own calendars, OpenTasks only shows those two calendars as well, while the subscribed calendars are not shown as VEVEN,VTODO. Now it _could_ be that DAVx5/ICSx5 already assumes subscribed calendars don't have VTODO, I'm not sure about that, or that the calendar components are queried in a different way than your Tasks app does (that would make sense).

I do know, however, that it's a recent issue, which could mean it came with either the update of Nextcloud 18.0.1/18.0.2, or - if relevant - the update of the Calendar app to 2.0.1/2.0.2.

[georgehrke]

Nextcloud server, it returns all subscribed calendars and shows them as also containing VTODOs. Don't know where Nextcloud gets this information from.

That is hardcoded in the server at the moment:
https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/CalDavBackend.php#L1894

What I'm currently wondering about: You seem to be using c-dav's findAllCalendars, you shouldn't be seeing subscriptions anyway. I will check why that happens.

[georgehrke]

Here we go: https://github.com/nextcloud/cdav-library/pull/272

[ltGuillaume]

Here we go: nextcloud/cdav-library#272

Well, not yet apparently...

[raimund-schluessler]

Subscriptions won't be shown anymore with #942, will come with the next release.