Talk: Feature Idea: Add prometheus metrics

Created on 4 Apr 2018  路  7Comments  路  Source: coralproject/talk

Do you want to request a feature or report a bug?

Feature

Intended outcome:

I'm trying to get metrics about how our system is performing. Things like comments per minute, requests per second, request latency, request error counts. Total comments. Stuff like that.

Actual outcome:

There is no metrics system implemented.

How to reproduce the issue:

Version and environment

I'm currently running talk 4.1.0

dev support feature idea help wanted

Most helpful comment

All 7 comments

We definitely have this on our roadmap! Already a Prometheus fan, so this seems achievable.

Awesome, we're rolling it out across our infra, so if it just showed up, that'd be awesome :D

As a sidebar this would be an awesome plugin - maybe there is an existing npm package or other library we could hook into?

There is a node prometheus client :heart_eyes:. Hook up for basic metrics appears to be just a few lines, supporting custom metrics also pretty straightforward.

Bumping the above comment for @icco (who just returned from his honeymoon! 馃帀 congratulations!)

I'll close this as we now have Prometheus support via https://github.com/coralproject/talk-plugin-prom

Woot, thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

icco picture icco  路  4Comments

raphaelpor picture raphaelpor  路  4Comments

Jetbo picture Jetbo  路  4Comments

cristiandean picture cristiandean  路  5Comments

jvert picture jvert  路  4Comments