Talk-android: FR: Dark theme

Created on 24 Jun 2018  Â·  9Comments  Â·  Source: nextcloud/talk-android

I am hoping that we will have a dark theme for this app, this is useful especially for those of us with amoled screens, also darker themes are easier on eyes.

thanks

enhancement good first issue design

Most helpful comment

@dan0xii given your great contributions to the Android app, would you be willing to work on this + https://github.com/nextcloud/talk-android/issues/250 here as well? I am, of course, more than willing to assist.

It would need some refactoring I assume since I didn't get around to extracting all the colours yet.

I'm sure the users would be grateful as your contributions have really been great in this area.

All 9 comments

i'm working in a dark theme for this app, i'll upload modified files when i finish

Dark theme will probably have to be calculated based on the existing colors
so when they are changed, dark colors change too

On Sat, 17 Nov 2018, 14:43 Page Asgardius <[email protected] wrote:

i'm working in a darkj theme for this app, i'll upload modified files when
i finish

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/talk-android/issues/207#issuecomment-439622187,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAWspst776fDXPG-Fls-OW3LDsZ_wTLks5uwCB2gaJpZM4U1CWr
.

dark theme patch.zip
Here my dark theme for Nextcloud Talk android app, Archive includes modified files from current master branch with a list of them in an unix txt file

Thanks @asgardius - I noticed you changed the colour files directly. Let me see if I can figure something out of this :)

@dan0xii given your great contributions to the Android app, would you be willing to work on this + https://github.com/nextcloud/talk-android/issues/250 here as well? I am, of course, more than willing to assist.

It would need some refactoring I assume since I didn't get around to extracting all the colours yet.

I'm sure the users would be grateful as your contributions have really been great in this area.

Sure, I'll take a look. I might be able to port the dark theme from the main app.

@dan0xii that would be awesome. Like I mentioned, might need a bit more work as colors are hardcoded at places, but you seem to be the expert in these things - so... :)

Remind me to get you a beer/wine/coffee/pancakes when we meet :)

I curse whenever I see hard-coded colours !

Remind me to get you a beer/wine/coffee/pancakes when we meet :)

I won't forget. :)

I curse whenever I see hard-coded colours !

This is the spirit!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tobiasKaminsky picture tobiasKaminsky  Â·  3Comments

szaimen picture szaimen  Â·  5Comments

markcs picture markcs  Â·  5Comments

nickvergessen picture nickvergessen  Â·  4Comments

pm-pm picture pm-pm  Â·  7Comments