Tachiyomi: [Bug] F-Droid can't build

[licaon-kter]

...as oss-licenses is not FOSS _(ironic right?)_ and fdroid flavor does not exclude it.

Ref: https://github.com/inorichi/tachiyomi/commit/ca47446b46e74ac4d366b7baa686cf3772b0ced9

Removing the include blindly will fail

> Task :app:kaptFdroidReleaseKotlin
Note: [1] Wrote GeneratedAppGlideModule with: [com.bumptech.glide.integration.okhttp3.OkHttpLibraryGlideModule]
> Task :app:compileFdroidReleaseKotlin
e: /home/strech/fdroiddata/build/eu.kanade.tachiyomi/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt: (10, 27): Unresolved reference: gms
e: /home/strech/fdroiddata/build/eu.kanade.tachiyomi/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt: (137, 52): Unresolved reference: OssLicensesMenuActivity

> Task :app:compileFdroidReleaseKotlin FAILED

FAILURE: Build failed with an exception.

[arkon]

I guess it's finally time to request for it to be taken down? :)

[licaon-kter]

Not sure Google might want to take that lib down...

/LE: not sure why everyone just can't live without this non-FOSS lib for some reason.

[CarlosEsco]

he's saying fdroid hasn't been officially supported in over a year.

[arkon]

I could probably replace it with something else, but our official stance has been that we don't support the F-Droid distributions for at least a year now too, so it's not particularly high priority.

I'll look into alternatives though, but it seemed like the easiest way of automatically getting the OSS licenses as a list.

[licaon-kter]

@CarlosEsco Y U can't into joke?

I understand the need for such a lib but the use of a closed source (open-source with close source dependencies actually) one to achieve this is rather baffling. :)

[arkon]

https://github.com/google/play-services-plugins/blob/master/LICENSE

It's licensed under APL 2.0.

[licaon-kter]

That's great, so it should just build with only FOSS deps?

> Task :app:checkFdroidReleaseDuplicateClasses

> Task :app:kaptFdroidReleaseKotlin
Note: [1] Wrote GeneratedAppGlideModule with: [com.bumptech.glide.integration.okhttp3.OkHttpLibraryGlideModule]
> Task :app:compileFdroidReleaseKotlin
e: /home/strech/fdroiddata/build/eu.kanade.tachiyomi/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt: (10, 27): Unresolved reference: gms
e: /home/strech/fdroiddata/build/eu.kanade.tachiyomi/app/src/main/java/eu/kanade/tachiyomi/ui/more/AboutController.kt: (137, 52): Unresolved reference: OssLicensesMenuActivity

> Task :app:compileFdroidReleaseKotlin FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileFdroidReleaseKotlin'.
> Compilation error. See log for more details

...oh, it depends on GMS which is not FOSS...right...

[opusforlife2]

@licaon-kter Which alternatives to this library do other apps on F-Droid use?

@arkon Pardon my ignorance, but how does adding this to an open milestone help you keep track of the issue if the issue itself is closed?

Guys, as an F-Droid user, I am perfectly fine with a simple plain text list, no matter if it is ugly, if it comes to that. Most users don't even access such a list in apps. This app is too useful to not be included in F-Droid.

[arkon]

I intend on trying this library, but it's pretty low priority.

I think F-Droid tried fixing the build on their end based on their build logs, but I'm not sure what they plan on doing (and we never really do, hence why we haven't officially recommended F-Droid in a long time).

Edit: I originally planned on just dropping the effort entirely until I stumbled upon the aforementioned library earlier this week, hence the won't fix label / closing.

[opusforlife2]

Great! That library seems to have been made specifically to address this problem.

[CarlosEsco]

@opusforlife2 may I ask why you are using the fdroid version vs the GitHub version?

[opusforlife2]

Guarantee of open... sourciness? Sourcicity? It's the same with FairEmail and so many others. It's not that I don't trust the developers, I just prefer the guarantee.

[CarlosEsco]

There is no guarantee?

From fdroid site themselves

F-Droid is a non-profit volunteer project. Although every effort is made to ensure that everything in the repository is safe to install, you use it AT YOUR OWN RISK. Wherever possible, applications in the repository are built from source, and that source code is checked for potential security or privacy issues. This checking is far from exhaustive though, and there are no guarantees.

[licaon-kter]

There's no guarantee that the actual code is harmless, not the build process. Garbage-in, garbage-out.

[opusforlife2]

It's about putting extra barriers between yourself and potential problems. This very issue is an example of what F-Droid does that I can't do manually.

[relyt29]

@opusforlife2 may I ask why you are using the fdroid version vs the GitHub version?

I use the fdroid version for a reason that isn't "guarantee of open sourcey-ness" (though I do think that's a legitimate reason, and they tell you within the fdroid app whether an app has "anti-features")

My reason is, FDroid is a package management tool where I get all my apps, and I don't want to be manually managing my Tachiyomi installation. I want to be able to update all of my applications at once, in one place, not manually remembering to check the tachiyomi github page on a frequent basis to check whether there's been an update to the application, this is literally the point of package management. Literally this is what auto-update is for.

It seems that Tachiyomi is written in the spirit of OSS, and FDroid is the de-facto OSS package manager for Android applications.

So then is the current expectation for Tachiyomi users that want their app to be kept up to date is to manually check the GitHub page for updates? Is there no auto-update functionality?

[arkon]

It does have auto-update functionality, which is why we don't recommend F-droid anymore since their builds are slow (or broken).

[CarlosEsco]

@relyt29 if you had downloaded from github previously you would have seen there has been an auto updater for 2+ years in this version. fdroid version has it stripped out. There is also an auto updater for the preview version of the app that gets weekly updates

[relyt29]

Ok so if I download the github version the app updates itself, got it

[opusforlife2]

Any luck with that library, @arkon?

[arkon]

It's been replaced for the next stable release.

[opusforlife2]

Awesome! Thanks a bunch!

[arkon]

FYI, 0.10.2/0.10.3 appear to be available in F-Droid now.

[opusforlife2]

Installed. New look is awesome. :)