Tachiyomi: Hide Individual Sources

[ThePreviousOne]

I'm starting this Issue because I don't think a pull request is the place to discuss a new feature

I imagine the simplest way of doing this would be something along the lines of adding a new entry to pref_sources, a list of some sort.

What I want to do is much more work and I probably can't even handle it (I detest UI) but I'm going to try.
I want to make the Spinner swipe-able, in that a user can remove a catalog from the spinner directly.

[null-dev]

I would avoid making the spinner swipeable, I don't think anyone will ever think of swiping stuff out of a spinner.

Maybe long-pressing the spinner to show a delete option or adding this option to the "Sources" screen would be a better option.

[inorichi]

I prefer using the sources screen.

I think the languages should show its list of sources and you can enable/disable them. The preference should store a list of disabled languages and sources, so that by default they are enabled.

I'm not sure how to do this in a single setting (we could use one for languages and one for individual sources but I think that's not the best approach)

[inorichi]

I've implemented this dialog (it doesn't store anything yet). It shows only the sources for the active languages (enabled in the setting above this one).

Thoughts?

[ThePreviousOne]

I think this would get bloated with a large list
I don't like when popups scroll it feels wrong

I was thinking something more like

I apologize I had to wip this up in Krita I Cannot do UI dev.

[ThePreviousOne]

With this you could potentially even get rid of the language selection

[inorichi]

That's what I thought at first, but if the list of languages grow, there's a bigger scroll.

[inorichi]

Furthermore, languages is something you change once (I think I'll add it to a setup screen when the app is first installed). The list of active catalogues will be updated more than once.

[ThePreviousOne]

I don't know what you're imagining I was simply suggesting adding a checkbox before the dropdown
Still I'd prefer this to a popup

[NoodleMage]

I prefer the look and feel of @inorichi's example in combination with a welcome screen like https://github.com/PaoloRotolo/AppIntro.

[ThePreviousOne]

Well either way I can't write it so I guess I don't care

[NoodleMage]

You may still care even if you can't code it ;). Your opinion and input are appreciated and @j2ghz seems to agree with you (according to the emoticon) ;). Just giving my opinion as well xD.

[ThePreviousOne]

Ok I'll revise that then. I don't care that much (I was going to get Really Passionate about it)

[inorichi]

I don't know what you're imagining I was simply suggesting adding a checkbox before the dropdown

I was referring to your suggestion of merging the language and source selection. If the full list of languages is shown there (even the ones you don't care about, most people will use at most 2-3 languages), you would have to scroll more content, even if all of the sections (languages) are collapsed.

[ThePreviousOne]

@NoodleMage Also I don't understand what Your purposing it sounds as though you are purposing that they be set only on first open. That'ed fine it it weren't not a one time thing, that would screw over anyone who's already installed the app but if its not then how do you change them them after the first time? ... my way?

@inorichi how may languages do you intend to support I can only really think of seven fits perfectly on a phone screen

[inorichi]

I don't intend to support anymore than the ones I implement, but I'm accepting PRs. Just keeping in mind the language list can grow.

you are purposing that they be set only on first open

No. It's just for the initial configuration. You can always change them from the settings.

[wopian]

I prefer ThePreviousOne's over a modal that would end up being scroll-able very soon (big ew) + PaoloRotolo/AppIntro

That's what I thought at first, but if the list of languages grow, there's a bigger scroll.

Just installed MangaRock to see what they've done to show their 26 manga sources. It takes exactly 3 scrolls to reach the bottom, which isn't all that bad (a little over 2 with Tachiyomi's Sources layout & padding)

On the on-boarding process you could show the available languages and the user tick the languages they want. Then show the list of sources by language.

Likewise on the source settings page, languages that are not selected would not have their sources shown which would reduce the amount of scrolling required. Although I somewhat prefer how MangaRock has done it by just showing all the languages and sources - just not the design :wink:

E.g something like this:

Although it'd have either a toggle or checkbox instead of the tick thing from the current source page.

[inorichi]

Current/unfinished design:

Enabled languages are shown at the top (though the order doesn't change when you enable/disable, it's only ordered when you open this screen).

For now there will be another screen for the selection (blame Batoto). I have to figure out how to manage selection and a catalog that requires login, but that's for another issue/day.

[ThePreviousOne]

just a thought but could you, for batoto remove the checkbox and make that te account "thingy"

if (notLoggedIn) batoto = false ... kind of thing

[inorichi]

See the last comment in the PR.