Tab-session-manager: TSM with hundreds of tabs - undeterministic behaviour when restarting FF

[przemolb]

Short description

I am using TSM on MacOS with (currently) FF 62.*.
I usually have a few hundreds of tabs opened. When I restart FF it looks like TSM is trying to load all of them and my FF is not usable (allocating more and more memory) so I have to kill the FF. And try to restart it again. And it repeats again.
After several attempts, it finally works.
I have Tab lazy loading setting enabled (!) all the time.

Platform information

• Platform (OS): MacOS High Sierra
• Version of browser: FF 60.* / 61.* / 62.*
• Version of Tab Session Manager: currently 4.1 (but the same happened with earlier releases as well)

[sienori]

Have you disabled the option to restore the previous session at startup?

[wbt]

@przemolb Have you tried it with tab lazy loading deselected/disabled, counterintuitive as that may be?

[przemolb]

@wbt the tab lazy loading says: When opening a session, the contents of each page are not loaded until you select the tab. If unchecked, memory usage greatly increases when a session is restored.
If unchecked ... so my understanding is that if I enable the tab lazy loading it will not load the content of the tab until I select the tab. So I keep it selected.
Am I right?

[przemolb]

@sienori what would that change? If I disable the option to restore the previous session at startup FF starts fine. But then when I open the saved session (with hundreds of tabs) FF becomes unusable ...

[wbt]

@przemolb I know it's a counterintuitive attempt strategy, but multiple comments on Issue #249 suggest that the lazy loading option may not be impacting memory usage in the expected way.

[przemolb]

@wbt Thanks - I didn't know (but should have known ...) that manuals doesn't meet ... reality ;-)

[przemolb]

@sienori, @wbt that doesn't work. I mean I didn't find any difference between the two modes - both are taking ages (I am writing this using Chrome because FF is unusable).
I don't understand why when I tick the tab lazy loading TSM is doing anything in the background. It should start as many tabs as were saved and keep them quiet. Until I select one of them. But it doesn't work that way - I have the dots shifting from left to right and back on all tabs.
And it eats up all the memory ...
I like this addon but I am always expecting the worst when I have to restart FF ...

[przemolb]

@sienori any debugging I can enable and help with investigating this issue?

[sienori]

Have you disabled Firefox option to restore the previous session?

It can not be used at the same time.

[przemolb]

@sienori yes I have disabled Firefox option to restore the previous session.

[hmijail]

Seeing the same problem for the last few versions of Firefox beta (right now at 64.0b3) on macOS. About 300 tabs, >50GB allocated - after which it slowly starts deallocating down to about 1 GB. It's so bad that I've gotten used to disabling TSM before trying to restore a session.
I'm using TreeStyleTabs too, which also has its own problems. Not sure if one might be affecting the other.

[przemolb]

@sienori is there any way I can enable debugging or verbose mode?

I can see that it is eating up all memory but don't know why :-(

[sienori]

@przemolb
Please try the following steps. Does memory leak occur?

1. Turn off the option
   
   
   
   • Auto save the session when window was closed
   
   
   • Restore previous session at startup
   
   
2. Open the session includes hundreds of tabs

[przemolb]

@sienori with these settings all is working very well - FF starts very quickly and is responsive and then TSM opens all windows and tabs very quickly as well. It seems that for now, this is the right workaround to use.
BTW I had updated my FF to 63.* before the change and it still was happening. Now it is much better.
Thanks @sienori !

[WPFilmmaker]

I don't know it is related but I never encountered any issue with TSM but since FF 63 update (on Linux), TSM makes FF slow and unresponsive...Disabling it fixes the issues. Am I the only one to have this problem?

[sienori]

@WPFilmmaker
Does the problem improve with the above steps?

1. Turn off the option
   
   
   
   • Auto save the session when window was closed
   
   
   • Restore previous session at startup
   
   
2. Open the session includes hundreds of tabs

[WPFilmmaker]

@sienori It seems that with FF 63 something changed and several users reported sluggish browser after the update (like here: https://old.reddit.com/r/firefox/comments/9riy4f/firefox_63_is_slow_at_loading_new_pages/ and here here: https://old.reddit.com/r/firefox/comments/9rtaad/with_version_630_youtube_lags_when_watching_1080p/ ).

I have no idea what changed but it seems that on linux certain addons make the browser slow.

I am using also decentraleyes and following this: https://git.synz.io/Synzvato/decentraleyes/issues/323 I disabled it and now the browser works fine without needing to change settings in TSM or disabling it.

It is very puzzling :/ do you have any idea if FF changed something which messes up with cetain addons in the 63 version?

[sienori]

@WPFilmmaker
It does not seem to be Tab Session Manager specific problem. I do not have any idea...
If you want to continue this discussion please post a new issue.

[sienori]

@przemolb
I fixed the memory leak problem! https://github.com/sienori/Tab-Session-Manager/commit/90390af779b9ea5c8fa19468f0a41054e93815b2