Syndesis: API Connector Form: Order and Spacing

[rhuss]

This is a...

[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Documentation issue or request

The problem

The spacing in the API connectors form is inconsistent, as well as the order

By convention, you normally enter the user first, then the password. not vice versa:

Expected behavior

"user" should come before "password", spacing between lines should be the same everywhere.

Screenshot

Related to #1709

[mcoker]

@rhuss can you provide the swagger file that enables those fields to be shown? I tried the swagger.json from my todo app and don't see those fields. https://photos.app.goo.gl/QU1qMlsA6nyZ96gv1

[zregvart]

@michael-coker looks like that's the TODO app Swagger file if you have a running minishift instance it should be available at https://todo-syndesis.$(minishift ip).nip.io/swagger.json. In case you can't access that I've created a gist with at https://gist.github.com/zregvart/af1f18e05d3911e2fa0779a3204509be

[mcoker]

@zregvart thanks, but that's the file I was using. I tried yours and got the same output in the screenshots from my previous comment. "HTTP Basic Authentication" is a radio button, not a select box/dropdown, and there are no form fields below it.

[zregvart]

@michael-coker perhaps it's this older version: https://github.com/syndesisio/todo-example/blob/1ff5cf90a9e1c6c60cd3701b3d077844527aa44a/swagger.json

[mcoker]

@zregvart same thing, still not seeing the form fields.

[deeleman]

You’re looking into different sections of the site, I’m afraid

[mcoker]

@deeleman ah! Found it now, thanks! @rhuss @zregvart sorry for the confusion :)

[mcoker]

@gashcrumb @deeleman that space is coming from a hidden input element with the text "Swagger specification of the service" shown via *ngIf="showHint" in syndesis-form-control.component.html.

1) What's the point of that text/input? I'm assuming the text shouldn't be shown (since it's associated with a hidden input field), and a form row shouldn't be generated for a hidden input.
2) I'm not sure where the data comes from that generates these form fields...

[gashcrumb]

Aha! Yes, we support hidden inputs to sneak extra data into the configured properties for a connection like this. We need the input to render on the page but not take up any actual space.

@seanforyou23 can you work with @michael-coker on this?

[mcoker]

That output also shows up on the connection details page, and the spacing of the values is off (which I can fix in CSS)

[mcoker]

@seanforyou23 I took a stab at hiding rows that have a hidden input field on the branch form-order-spacing.

[gashcrumb]

@michael-coker want to create a PR with that branch? Might need to rebase it first too just to be on the safe side...

[mcoker]

@gashcrumb https://github.com/syndesisio/syndesis/pull/2044