Symplify: [ChangelogLinker] Creates multiple Unreleased sections

[shyim]

https://github.com/FriendsOfShopware/FroshPluginUploader/commit/7d48f4f8223d5f9e1b0f9aacfe06d7446acdfff9
https://github.com/FriendsOfShopware/FroshPluginUploader/commit/988e40da6a98f6de89cb6ab1672081c252e3c990

Is this intended?
Or should I run it only before any release? Currently running on any push

[TomasVotruba]

It was not used on CI yet, just before release.

But I think it should be smart enough to append new issues to Unreleased section instead of creating a new one.

[shyim]

Looks like the could is currently not built for that. It searches for the placeholder and puts just in there.

Maybe an solution could be to add a placeholder per version and try to add it here first, when it fails add a new section

[TomasVotruba]

It could look for \n## Unreleased?

[samsonasik]

@TomasVotruba could you give me information how to reproduce it? Thank you.

[TomasVotruba]

I think this method needs to be covered with test:
https://github.com/symplify/symplify/blob/ad443e522d7532328eceb2a13ee39ba0a4ba5a66/packages/changelog-linker/src/FileSystem/ChangelogFileSystem.php#L67

Where:

• $newContent contains ## Unreleased
• existing content contains ## Unreleased
• and testg merging them together

When I look at the ChangelogFileSystem code, it will require some refactoring for better testing. It's very badly written.

[samsonasik]

Ok, I will try.