Sylius: New version notification does not compare versions correctly

[teohhanhui]

| Q | A
| ---------------- | -----
| Bug report? | yes
| Feature request? | no
| BC Break report? | no
| RFC? | no
| Sylius version | 1.x

https://github.com/Sylius/Sylius/blob/v1.1.5/src/Sylius/Bundle/AdminBundle/Resources/private/js/sylius-notification.js#L94

It can be solved by using https://www.npmjs.com/package/semver to perform the version comparison.

I have not submitted a PR because Sylius does not have a module bundling / loading system in place yet.

[pamil]

Why isn't it correct?

[teohhanhui]

Versions should be compared by semver rules.

[pamil]

In which cases does it give an incorrect result?

[teohhanhui]

For example, 1.1.6-DEV > 1.1.5

[teohhanhui]

@pamil Now, when you've tagged a pre-release version (1.2.0-BETA), it also screws up the update notification for all existing installations. :stuck_out_tongue:

[teohhanhui]

semver.satisfies('1.2.0-BETA', '^1.1.6');
// false

semver.satisfies('1.2.0', '^1.1.6');
// true

[teohhanhui]

But if we want a quick fix, we could use https://github.com/composer/semver and do an AJAX call. WDYT? Personally I'd prefer if we wait to fix it the proper way, since this is not a serious bug.