Sylius: Combined buttons look strange with translations

Created on 22 Feb 2017  ·  2Comments  ·  Source: Sylius/Sylius

Some languages have longer words for "or", for example the german "oder" looks strange in the buttons in the Admin-UI.

Possibly there are other languages with even longer words.

bildschirmfoto 2017-02-22 um 21 13 49

UX

Most helpful comment

Maybe we can remove the {{ 'sylius.ui.or'|trans }} completely?
IMO it does not provide any value.

Alternatively I could also place the word between the two buttons (not in a circle)
and improve the handling of foreign languages with longer translations for "or".

WDYT? I would provide a PR if you comment on that issue.

All 2 comments

Maybe we can remove the {{ 'sylius.ui.or'|trans }} completely?
IMO it does not provide any value.

Alternatively I could also place the word between the two buttons (not in a circle)
and improve the handling of foreign languages with longer translations for "or".

WDYT? I would provide a PR if you comment on that issue.

@psren +1 for removing it, not much value and I'd rather not waste time on trying to make it look pretty with so many locales. :)

Was this page helpful?
0 / 5 - 0 ratings