Sylius: When not "admin-logged", /admin redirects to /login

[tchapi]

... I guess it should rather redirect to /admin/login, no ?

It's the case on the demo site, too.

[Zales0123]

Unfortunately, Symfony is incredibly strict with its firewalls paths patterns and as it's configured now, you will be redirected to /admin/login after accessing /admin/ not /admin.

[michalmarcinkowski]

How about creating a redirect route?

sylius_admin_panel:
    path: /admin
    defaults:
        _controller: FrameworkBundle:Redirect:redirect
        route: sylius_admin_dashboard
        permanent: true

[pamil]

Why don't we just change the pattern from /admin/.* to /admin.*? :)

[michalmarcinkowski]

Wouldn't it match e.g. /adminstrable-product-permalink? I know there are little words starting with admin, but still we can have e.g. static pages like /administering-something etc.

[lchrusciel]

(/admin/.*|/admin$) ?

[pamil]

/admin(?:/.*)?$?

[michalmarcinkowski]

Waiting for PR with proper fix 😄

[lchrusciel]

@michalmarcinkowski done

[emodric]

I think redirect route should still be created.

With this patch, but without the redirect route, /admin correctly redirects to /admin/login, but then after login, it gets redirected back to /admin which doesn't work.

[pjedrzejewski]

@emodric Good catch! @lchrusciel Care to submit another PR? Thanks!

[lchrusciel]

@pjedrzejewski sure, I am on that.