Sylius: [RFC] Usage of Doctrine naming strategy

Created on 1 Jul 2016  路  5Comments  路  Source: Sylius/Sylius

Related: https://github.com/Sylius/Sylius/pull/5395#discussion_r69283483

We already have some conventions:

  • model class Sylius\...\Model\FooBar has table name sylius_foo_bar
  • model property Model::$fooBar has column name foo_bar

We may enforce them with Doctrine naming strategy, remove all existing hardcoded table names / column names and just forget about it.

RFC

All 5 comments

There's an another issue for that: https://github.com/Sylius/Sylius/issues/1837, but it's quite old.

Last call before alpha - should we enforce the naming convention?

Anyone?

I'd prefer to keep them in the files. It is not much overhead, we have not touched them for a long time and this approach is mostly known for Symfony devs. Naming strategy is something that not everyone is aware of.

Agreed, we don't know how this will affect custom entities too.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ping86 picture ping86  路  3Comments

mezoni picture mezoni  路  3Comments

mikemix picture mikemix  路  3Comments

stefandoorn picture stefandoorn  路  3Comments

crbelaus picture crbelaus  路  3Comments