Swoole-src: Debugging and PHP7.4

Created on 28 Jan 2020  路  12Comments  路  Source: swoole/swoole-src

So far we have been able to debug with sdebug provided by @mabu233,
i have tried to provide a PR for xdebug 2.9 (which has PHP:7.4 compatibility) but i failed.
Are there any plans to have debugging options for Swoole on PHP:7.4 ?
Thanks in advance for the help & feedback guys

Most helpful comment

@nick-zh xdebug_2_9 is created and synced with Xdebug. Branch sdebug_2_9 is also created.

All 12 comments

The Swoole team is considering to fork the repository and maintain it. We will post an update here once it's there. Thanks

Sdebug has been forked. A pull request was made to merge changes from nick-zh:sdebug_2_9 but there were unresolved conflicts.

Thank you very much for the update @deminy , i will be busy for the next couple of weeks. I will get to it probably in March unless somebody gets it working before me
The branch i created was failing, i wanted mabu's feedback, since i am not that versed with xdebug anyway.

I will also open my second PR again, which adds the xdebug:2.9 branch, since my PR is branched on xdebug:2.9, this is why there are conflicts, since the current default branch is xdebug:2.7

@deminy silly me, i cannot add a non-exsting branch to your sdebug fork since i am not a contributor, can maybe one of you guys create and push the current xdebug_2_9 branch to sdebug as well? thx a lot in advance :heart:
i created one to at least update the master as well
Edit: From the xdebug_2_9 branch, please create the sdebug_2_9 branch so i can base my PR on it

I was told that some Swoole team members were reviewing the changes. Since there are too many commits involved, it could take a while. Thanks

@deminy you can disregard the old pr, there are so many changes because the master is still xdebug_2_7 but my pr was based on xdebug_2_9. This is why i need you guys to copy the xdebug_2_9 branch from xdebug to sdebug and also create an sdebug_2_9 branch from xdebug_2_9 so i can start merge the changes again. I can't create a PR against branches that don't exist.
I am not sure if you need to review my PR against the master, i simply synced the newest xdebug changes from master.
Thanks in advance

@nick-zh xdebug_2_9 is created and synced with Xdebug. Branch sdebug_2_9 is also created.

@doubaokun thank you very much!

Closing this thread now.

why was it?

just as an update, the sdebug_2_9 branch (https://github.com/swoole/sdebug) can now be used to debug with php:7.4

Was this page helpful?
0 / 5 - 0 ratings

Related issues

daslicht picture daslicht  路  4Comments

rovico picture rovico  路  4Comments

lotarbo picture lotarbo  路  4Comments

pthreat picture pthreat  路  3Comments

andreybolonin picture andreybolonin  路  4Comments