Switchyomega: Error log should not include user-identifying or sensitive information

[olloff]

This.

For now error log can include Options#reset and Options#patch parts with proxy address:port and auth data. Error log should erase this data or, at least, ask for user consent and highlight it in log.

"fallbackProxy"
     "port"
     "host"
"proxyForHttp"
     "port"
     "host"
"proxyForHttps"
     "port"
     "host"
"proxyForFtp"
     "port"
     "host"
"auth"
     "proxyForHttp"
          "username"
           "password"
     "proxyForHttps"
          "username"
           "password"
     "proxyForFtp"
          "username"
           "password"

[celeron533]

Reproduced on my Chrome 60.

[FelisCatus]

Good catch. I think I totally forgot this. Let me patch it.

[FelisCatus]

For now please restart Chrome after you change options. The logs will be cleared.

Most issues can be reproduced without changing options though.

[FelisCatus]

            "auth": {
                "fallbackProxy": {
                    "password": "<secret>",
                    "username": "<secret>"
                }
            },
            "fallbackProxy": {
                "host": "<secret>",
                "port": "<secret>"
            },

Now you can only see a bunch of <secret> in the logs for host, port, username and password. Please let me know if you have other concerns. Note that we're not going to remove profile names since they are usually necessary to debug issues.