Swiftlint: Rule request: Vertical alignment of collection types

Created on 1 Aug 2018 · 4Comments · Source: realm/SwiftLint

New Issue Checklist

[x] Updated SwiftLint to the latest version
[x] I searched for existing GitHub issues

Rule Request

This issue is to propose the addition of a new style rule that would check for vertical alignment of collection types (such as with arrays, dictionaries, and sets).

Why should this rule be added?

The proposed rule would ensure that collections that span multiple lines would be vertically aligned on the first character, or on colons for dictionaries.

Provide several examples of what _would_ and _wouldn't_ trigger violations.

Triggering examples

// ❌ Coordinates not aligned on first character
let coordinates = [
    CLLocationCoordinate2D(latitude: 0, longitude: 33),
        CLLocationCoordinate2D(latitude: 0, longitude: 66),
    CLLocationCoordinate2D(latitude: 0, longitude: 99)
]

// ❌ Strings not aligned on first character or on colons
let meals = [
            "breakfast": "oatmeal",
            "lunch": "sandwich",
"dinner": "burger"
]

// ❌ Integers not aligned on first character
var evenNumbers: Set<Int> = [
    2,
  4,
    6
]

Non-triggering examples

// ✅ Dictionary keys aligned on first character
let colorDictionary: [NSNumber: UIColor] = [
    0: .clear,
    5: .white,
    10: .green,
    15: .yellow,
    20: .red
]

// ✅ Dictionary keys aligned on colon
let colorDictionary: [String: UIColor] = [
          "mild": .green,
      "moderate": .yellow,
        "severe": .red
]

✅ Array of strings aligned on first character
let pets = [
    "cat",
    "dog",
    "fish"
]

Should the rule be configurable, if so what parameters should be configurable?

No, I don't believe the rule should be configurable.

Should the rule be opt-in or enabled by default? Why?

The proposed rule should be enabled by default to promote consistency in alignment, which is enforced through other rules. I'm open to this being different though.

rule-request

Source