Swiftlint: Rule Request: Flag `assert(false, …)` and `precondition(false, …)`

[lilyball]

New Issue Checklist

• [X] Updated SwiftLint to the latest version
• [X] I searched for existing GitHub issues

Rule Request

My coworkers keep adding code like

if (someCondition) {
    assert(false, "Error message goes here")
}

While this is necessary in Obj-C, in Swift we should be using asssertionFailure("Error message") (and preconditionFailure("Error message")) instead. There's literally no reason to be writing assert(false, …) beyond lack of knowledge of assertionFailure(_:).

I don't see any configuration necessary here, and this should be opt-out because it's generally useful and the only reason to disable it is because you have hundreds of violations and don't want to fix them.

[ornithocoder]

Hi @kballard, do you have plans to work on it? Otherwise I'll take it.

[lilyball]

@ornithocoder I have no plans on doing this myself, so please go ahead.