Swiftlint: [Swift 4.1]`explicit_type_interface` and `identifier_name` violations are produced by local variables

Created on 27 Jan 2018 · 6Comments · Source: realm/SwiftLint

New Issue Checklist

[x] Updated SwiftLint to the latest version
[x] I searched for existing GitHub issues

Bug Report

Complete output when running SwiftLint, including the stack trace and command used

# Xcode 9.2
$  echo 'func f() { let snake_case = 1 }'|swiftlint lint --use-stdin --enable-all-rules
<nopath>:1:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
<nopath>:1:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly. (explicit_top_level_acl)
Done linting! Found 2 violations, 0 serious in 1 file.
# Xcode 9.3 beta 1
$  echo 'func f() { let snake_case = 1 }'|DEVELOPER_DIR=/Applications/Xcode-beta.app swiftlint lint --use-stdin --enable-all-rules
<nopath>:1:1: warning: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
<nopath>:1:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly. (explicit_top_level_acl)
<nopath>:1:12: error: Identifier Name Violation: Variable name should only contain alphanumeric characters: 'snake_case' (identifier_name)
<nopath>:1:12: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
Done linting! Found 4 violations, 1 serious in 1 file.

Environment

SwiftLint version (run swiftlint version to be sure)?
confirmed on 0.24.2 and master
Installation method used (Homebrew, CocoaPods, building from source, etc)?
Homebrew
Paste your configuration file:

# none

Is this expected behavior?

question

Source

norio-nomura

All 6 comments

I'd say yes, this is expected behavior now that https://github.com/realm/SwiftLint/issues/136 will be fixed.

We could add configurations if we think it's too noisy though.

marcelofabri on 27 Jan 2018

Thanks! understood. 👍

norio-nomura on 27 Jan 2018

@marcelofabri It'll be great if there's a configuration for this. We only want this for class and struct properties so that the generated interface works well, but continue having type inference for local variables.