Swiftgen: swiftlint error for generate uiimage asset

[romk1n]

Started to have this error:

UIImage+Asset.swift:46:84: error: Superfluous Disable Command Violation: SwiftLint rule 'type_name' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

and the line in question is

// swiftlint:disable identifier_name line_length nesting type_body_length type_name

what should be the fix for this? swiftlint version 0.22.0

[djbe]

Ah, that's because we disable some rules because we can't predict what will be generated.

We'll need to add superfluous_disable_command to our disable comment.

[romk1n]

@djbe is that new error? seems like triggers a build failure ?

[AliSoftware]

Yeah it seems that it's a new rule which was introduced in SwiftLint 0.22. How meta of SwiftLint to long is own annotations 😁

[djbe]

@romk1n as a temporary solution (while we address this issue), you can either:

• add the generated files to your swiftlint excluded files.
• use a custom template to add the superfluous_disable_command.

[romk1n]

yes thats what I did indeed.

[AliSoftware]

Mmmmh I just tried to add the comment to disable superfluous_disable_command but it seems it's too meta for SwiftLint to be able to disable it inline… :-/

[AliSoftware]

@romk1n Note that I created the PR https://github.com/SwiftGen/templates/pull/83 which we'll merge very soon so it's gonna be in the next release of SwiftGen (probably this week-end)… but you'll also need to update SwiftLint to 0.23.1 as they also fixed a bug related to this superfluous_disable_command rule recently.

Once you've update to SwiftLint 0.23.1 AND that we'll have released the next version of SwiftGen to include the fix on the bundled templates on our end, all should be good again :wink: