Swiftformat: Incorrect indent introduced in 0.45.3

Created on 8 Aug 2020  路  5Comments  路  Source: nicklockwood/SwiftFormat

An extra two spaces of indent are added at lines 405-408 of https://github.com/firebase/firebase-ios-sdk/blob/master/Firestore/third_party/FirestoreEncoder/FirestoreDecoder.swift

 $ swiftformat --indent 2 --maxwidth 100 --wrapparameters afterfirst -disable sortedImports,unusedArguments,wrapMultilineStatementBraces --lint   Firestore/third_party/FirestoreEncoder/FirestoreDecoder.swift
Running SwiftFormat...
(lint mode - no files will be changed.)
/Users/paulbeusterien/gh9/firebase-ios-sdk/Firestore/third_party/FirestoreEncoder/FirestoreDecoder.swift:405:1: warning: (indent) Indent code in accordance with the scope level.
/Users/paulbeusterien/gh9/firebase-ios-sdk/Firestore/third_party/FirestoreEncoder/FirestoreDecoder.swift:406:1: warning: (indent) Indent code in accordance with the scope level.
/Users/paulbeusterien/gh9/firebase-ios-sdk/Firestore/third_party/FirestoreEncoder/FirestoreDecoder.swift:407:1: warning: (indent) Indent code in accordance with the scope level.
/Users/paulbeusterien/gh9/firebase-ios-sdk/Firestore/third_party/FirestoreEncoder/FirestoreDecoder.swift:408:1: warning: (indent) Indent code in accordance with the scope level.
bug fixed in develop

All 5 comments

@paulb777 this appears to already be fixed in 0.45.3 (I can reproduce it in 0.45.2).

Hmm, I'm seeing the opposite. Maybe we have a disconnect about what the right format is?

Shouldn't the right closing brace at line 408(411 in your version) be in the same column as the p of public on line 410(413)?

If not, why?

@paulb777 ah, sorry, I misunderstood. I assumed that the file you had linked to was the correct version, not the one with the wrong indent already applied.

I suspect the braces here are being mistaken for a closure. I'll investigate and try to fix it in the next release.

@paulb777 I pushed a fix to the develop branch. This will land in 0.45.5 (probably in a few days).

@paulb777 fixed in 0.45.5.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DagAgren picture DagAgren  路  4Comments

MaxDesiatov picture MaxDesiatov  路  4Comments

soranoba picture soranoba  路  3Comments

mdiep picture mdiep  路  3Comments

PompeiaPaetenari picture PompeiaPaetenari  路  4Comments