Swiftformat: Initializing from a metatype value must reference 'init' explicitly

[pablosichert]

Formatting

struct Foo {}

let Bar = Foo.self
let bar = Bar.init()

results in

struct Foo {}

let Bar = Foo.self
let bar = Bar() // 🛑 Initializing from a metatype value must reference 'init' explicitly

[nicklockwood]

@PabloSichert thanks for reporting this. I'll see what I can do to fix it. In the meantime, adding

// swiftformat:disable:next redundantInit

immediately above the line let bar = Bar.init() should solve the problem.

[nicklockwood]

@PabloSichert I've added a known issue about this in the README file, with the suggested workaround.

Fixing it for the general case will not be possible because SwiftFormat doesn't have enough contextual information to detect legitimate vs illegitimate use cases. I might be able to handle the common cases so that there are fewer false positives though (e.g. where the metatype variable is defined locally in the same scope as it is used).

I don't think this comes up often enough to be worth disabling the rule by default, but I'm open to doing that if there are many more reports. I'll leave the ticket open for now.