Sway: XWayland popups are poorly sized

Created on 1 Jul 2016 · 16Comments · Source: swaywm/sway

Hey,

XWayland popups are poorly sized, I tested on firefox. For example, try going to the following url to trigger http auth: http://www.httpwatch.com/httpgallery/authentication/authenticatedimage/default.aspx?0.7424363763312372
The popup window for the password is very poorly sized (and I also can't resize it from the keybindings, but I guess that's a different matter).
bla

Thanks.

bug

Source

tasn

👍13

Most helpful comment

Or the uMatrix (firefox extension) window that is poorly sized, accepts input in areas in doesn't render to and etc...

tasn on 1 Jul 2016

👍3

All 16 comments

Or the uMatrix (firefox extension) window that is poorly sized, accepts input in areas in doesn't render to and etc...

tasn on 1 Jul 2016

👍3

This bug is still present in:

wlc 0.0.5
sway 0.9

onny on 3 Aug 2016

This bug is still present in:

wlc-git (from today)
sway-git (from today)
wayland 1.12.0
wayland-protocols 1.7

onny on 21 Sep 2016

Still an issue on sway 0.15.0, especially with Firefox's uMatrix pop-up, where clicks aren't detected properly.

asymmetric on 9 Dec 2017

Has this been fixed as part of the hackathon? :)

asymmetric on 1 Apr 2018

Yep.

ddevault on 1 Apr 2018

👍1

Can reproduce again in 1.0.

emersion on 5 Jul 2018

Any status update?

sqrtroot on 24 Sep 2018

Status update: please send patches to fix this.

emersion on 24 Sep 2018

Any insight as to where this problem stems from, a place to start making a patch to fix this?

sqrtroot on 24 Sep 2018

I poked around in xwayland.c's handle_map. In my case the size that it's committing with is 299x186, which is too small. It seems to be a problem with Firefox or xwayland.

RyanDwyer on 24 Sep 2018

GNOME doesn't have this issue so its unlikely. There's a preferred size alongside the min and max size for xwayland views, maybe there's something to do about it.

emersion on 24 Sep 2018

I don't think this is us

ddevault on 14 Oct 2018

Well, I do think this is us.

emersion on 14 Oct 2018

oh.

ddevault on 14 Oct 2018

😄1

Firefox submits two configure requests for any surface it intends to have mapped I think.
The first one requests the correct geometry, but the second passes 1x1 causing it to shrink.
https://github.com/swaywm/wlroots/blob/master/xwayland/xwm.c#L804
This handles the event, but always handles it as an attempt to set the geometry even though that might not be the case.
https://tronche.com/gui/x/xlib/events/structure-control/configure.html
I think these are the other actions it can take.
https://tronche.com/gui/x/xlib/window/configure.html#XWindowChanges
If I print value_mask for each event I get 12(width and height) for the first one and 64(StackMode) for the second. Perhaps it is trying to raise the window.