Swagger: `extends` broken for DTOs

Created on 9 May 2018 · 5Comments · Source: nestjs/swagger

using extends in DTO classes appears to be broken between 1.2.2 and 1.3.0.

minimal example:

class foo {
    @ApiModelPropertyOptional()
    public prop?: string;
};

class bar extends foo {
    @ApiModelPropertyOptional()
    public otherProp?: string;
}

@Controller("leads")
@ApiProduces("application/json; charset=utf-8")
export class LeadsController {
    constructor() {}

    @Get()
    @ApiResponse({ status: 200, type: bar })
    public find(): bar {
        return {
            prop: "asdf",
            otherProp: "asdf"
        }
    }
}

using this controller, I get an error in swagger-ui: Uncaught ReferenceError: foo is not defined.

The generated swagger actually looks correct:

   "paths": {
        "/leads": {
            "get": {
                "responses": {
                    "200": {
                        "description": "",
                        "schema": {
                            "$ref": "#/definitions/bar"
                        }
                    }
                },
                "produces": [
                    "application/json"
                ],
                "consumes": [
                    "application/json"
                ]
            }
        }
    },
    "definitions": {
        "bar": {
            "type": "object",
            "properties": {
                "prop": {
                    "type": "string"
                },
                "otherProp": {
                    "type": "string"
                }
            }
        }
    }

but when swagger ui tries to consume it, it looks like this: