Swagger-codegen: [PHP] String length validation in models

[dParadiz]

Description

When generating models with string properties having maxLength or minLength, strlen is used for validating max/min length of the string. While this works for English language it will not work properly for other languages such as German, since strlen returns number of bytes not number of character.

Swagger-codegen version

2.3.0

Swagger declaration file content or url

Any swagger declaration file having models with string properties and maxLength or minLength.
For example:

definitions:
  Person:
    Name:
      type: "string"
      maxLength: 4

Command line used for generation

See command line for php code generation

Steps to reproduce

1. Generate client
2. Query api that returns models with string properties within min/max range with characters öüä
3. Model validation should fail despite having number of characters in required range

Related issues/PRs

Suggest a fix/enhancement

Use mb_strlen instead of strlen. Also add option to define encoding to use for mb_strlen.

[ackintosh]

@dParadiz Nice catch! Can you attach a PR for this?

[dParadiz]

@ackintosh What do yo mean by PR? I could not fund any similar or related reported issues.

[ackintosh]

@dParadiz I'm sorry for my poor English. 💦
Could you create a PR which fixes this issue?

[dParadiz]

@ackintosh Sorry, it's just my understanding of abbreviation PR. Do you mean that I add proposal for this issue or is PR something else?

[ackintosh]

Ah, PR is Pull Request 💡

[ackintosh]

I'll submit the Pull Request which fixes this issue later.

[wing328]

@dParadiz the issue has been fixed by the PR filed by @ackintosh

Please pull the latest master to give it another try.

[dParadiz]

@wing328 I can confirm that it works in my case.

[wing328]

@dParadiz thanks for the confirmation