Svg-sprite-loader: Update extract text plugin version [WebPack2]

Created on 17 Sep 2016  路  7Comments  路  Source: JetBrains/svg-sprite-loader

Hi,

In extract-svg-plugin.js, the syntaxe of extract-text-webpack-plugin is deprecated :
this.extractPlugin = new ExtractPlugin(this.id, this.filename, this.options);

should be something like :
this.extractPlugin = new ExtractPlugin({ filename: this.filename, id: this.id});

There might be other changes as it's not enough to make this work again.

Thanks a lot.

help wanted

Most helpful comment

@kisenka I made sample repo with test:

git clone https://github.com/farwayer/svg-sprite-loader-bug
cd svg-sprite-loader-bug
npm install
npm start

All 7 comments

Hi, is this issue will be solved ? Or is there a workaround I could do while waiting for it ?
thanks

Sorry guys, not enough time. PR is very welcome!

Hi,

Sorry but I didn't manage to make this work till now

Shipped with 0.0.30. Also now you can omit extract=true option, loader will try to detect extract mode automatically.

@kisenka Thanks for fixing. Now extracting working well. But one problem still exists. ExtractSVGPlugin outputs [object Object] as id.

@farwayer could you tell me more about your setup? Example of SVG file will be useful too.

@kisenka I made sample repo with test:

git clone https://github.com/farwayer/svg-sprite-loader-bug
cd svg-sprite-loader-bug
npm install
npm start
Was this page helpful?
0 / 5 - 0 ratings