Svelte: InputOutputToggle doesn't completely hide the browser checkbox

Created on 8 Jul 2020  路  7Comments  路  Source: sveltejs/svelte

Describe the bug
The InputOutputToggle component doesn't completely hide the browser checkbox on mobile safari, there are still parts of the checkbox that are visible which results in InputOutputToggle looking weird. The rectangle is only visible when the checkbox in its off state.

toggle

Version: AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1

REPL browser compat has pr

Most helpful comment

Could this be updated to has PR?

All 7 comments

@Conduitry I don't quite understand why the issue was moved. I thought that the bug is related to https://github.com/sveltejs/svelte/blob/master/site/src/components/Repl/InputOutputToggle.svelte which is located in the main sveltejs repo. Is it planned to move that component to this repo as well?

Whoops! You are right. I will transfer this back.

I made a PR in site-kit.

Could this be updated to has PR?

Aha, I was trying to fix this issue but it was already fixed here. I swore I saw a fix but couldn't find it.

In my solution I am simply adding border: none to he code.

Anything else on my end to get this PR to the finish line?

Redeployed the site with @benschac's fix 馃嵒

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mmjmanders picture mmjmanders  路  3Comments

plumpNation picture plumpNation  路  3Comments

rob-balfre picture rob-balfre  路  3Comments

1u0n picture 1u0n  路  3Comments

thoughtspile picture thoughtspile  路  3Comments