Svelte: Property "muted" for <audio> and <video>

Created on 10 Jun 2019  Â·  6Comments  Â·  Source: sveltejs/svelte

Hello!

Now <audio> and <video> components provide 3 two-way binding tags: currentTime, paused and volume.

I'd like to send a PR with the muted property.

This property is not the same as setting volume to 0. It has slightly different mechanics and in some cases is really needed (i.e. modern browsers disallow autoplay non-muted video. setting volume to 0 doesnt work).
Also it is useful in some scenarios (i. e. if we want to make volume controller like youtube one, where you can mute sound by the button, and the volume slider is still visible and showing volume level, which would be actual after unmutting)

Is this PR welcome?

PS. commit is already in my fork: https://github.com/fend25/svelte/commit/a37ee816769f1f6eabf53c912b2331134aae61a1

(there are some unrelated linting fixes - I did the linting)

enhancement

Most helpful comment

This has been released in 3.23.0.

All 6 comments

Yes please! A PR for bind:muted would be appreciated! Please also include in the PR an update to https://github.com/sveltejs/svelte/blob/master/site/content/docs/02-template-syntax.md to mention the new binding.

Hi guys, may I enquire about the state of this PR @fend25 or @Conduitry as I'd love to have the use of bind:muted in my video component. Many thanks.

Draft PR for this, but it needs some fixing before it's good. https://github.com/sveltejs/svelte/pull/4690

Hello. Is there any progress on this PR?
Docs referes to muted binding
But I am getting an error

ValidationError: 'muted' is not a valid binding

Sorry, I guess this means we've been officially bitten by not having a separate branch to deploy docs from. This feature is in master, as are its docs, but it hasn't been released yet. The docs just came along when I was deploying some _other_ documentation fixes from master. This should be released soon.

This has been released in 3.23.0.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AntoninBeaufort picture AntoninBeaufort  Â·  3Comments

Rich-Harris picture Rich-Harris  Â·  3Comments

st-schneider picture st-schneider  Â·  3Comments

sskyy picture sskyy  Â·  3Comments

rob-balfre picture rob-balfre  Â·  3Comments