Survey-library: Radio buttons & checkboxes do not have unique ID attributes

[ekim-novus]

Are you requesting a feature, reporting a bug or asking a question?

Reporting a bug

What is the current behavior?

The radio buttons and checkboxes that belong to the same group all have the same ID attribute, when instead IDs should be unique.

What is the expected behavior?

The individual radio buttons/checkboxes should either have different IDs, or the ID should maybe be moved to the containing <fieldset> tag.

How would you reproduce the current behavior (if this is a bug)?

Visit any survey with a radiogroup or checkbox question.

Provide the test code and the tested page URL (if applicable)

Tested page URL: sample radio group in the documentation

Specify your

• browser: Chrome
• browser version: 69.0.3497.100
• surveyjs platform (angular or react or jquery or knockout or vue): react
• surveyjs version: 1.0.53

[dmitrykurmanov]

this is definitely the bug because of https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id

The id global attribute defines a unique identifier (ID) which must be unique in the whole document.

[dmitrykurmanov]

@ekim-novus thank you for the reporting. Fix will be available in the next minor update.

[ekim-novus]

Thanks @dmitrykurmanov !

[zech]

Hi,

I think at least for RadioButtons this bug is introduced (again). We're using it with React and a column count of 4 and it triggers warnings in console.

I suspect this code is the issue because the index is not respecting the column count (ci) in line 49:

https://github.com/surveyjs/survey-library/blob/595c8fc065d30b7070367046d9e70f8d84bffa20/src/react/reactquestionradiogroup.tsx#L48-L50

Tagging @dmitrykurmanov. I hope it's okay to append it to an existing issue.

[dmitrykurmanov]

@zech the bug fixed via the https://github.com/surveyjs/survey-library/commit/f7986e09d033273614184c652f1d1bfb68cf1867. Fix will be available in the next minor release. Thank you for the reporting.

[dmitrykurmanov]

@zech unfortunately I've reverted that changes for survey-knockout because of technically problems with knockout and survey-creator. We will think about better decision.

PS for react and vue it will work as expexted and I didn't revert the changes.

[zech]

Thanks. The changes in react will be sufficient for now i think.