Please review my latest project:
Many thanks
Martin Parker
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 馃 . Any questions let us know.
Hi @RasPiPkr 馃槂, I took a look at your project and the project looks great 馃憤. I do think there are some areas where it can improve and incentivize contributions from new contributors. Here is my feedback:
README can make use of more markdown features to emphasize important parts. This helps the reader get straight to the info they need and are looking for, for example:... command line enter:
pip3 install pychromecast <-- Used for voice announcement on Google Home.
pip3 install beautifulsoup4 <-- Used for web scraping for sunrise and sunset times.
Hope that helps 馃槂
Great idea, I'm new to documenting my repositories.
Cheers 馃憤馃榿
Looks great @RasPiPkr ! And great feedback @BOLT04 馃憤
@RasPiPkr I will review in a future video / live stream too 馃 - thanks for sharing your repo
That would be great thanks :thumbsup:
The project looks really great @RasPiPkr 馃憤
As David said, it's great that you're using issues to organise and document the repository.
It would be really great, if you could add issue templates and labels: these would help you prioritise issues that are more essential or of specific areas, and might also help contributors in finding an issue that they would like to work on.|
To maintain code quality, and make your tasks as a maintainer slightly easier, you could perhaps add a github action to lint and build the project?
the ones provided by github: https://github.com/RasPiPkr/myHome/actions/new
Great idea, I will look in to it tomorrow.
Thank you for your suggestion.
Reviewing on a live stream https://youtu.be/oM8rBNyiwPY
Looks good, some suggestions: