Support: Please review my current open source project

Created on 10 Dec 2020  路  8Comments  路  Source: EddieHubCommunity/support

Please review my latest project:

Many thanks
Martin Parker

open source review

All 8 comments

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 馃 . Any questions let us know.

Hi @RasPiPkr 馃槂, I took a look at your project and the project looks great 馃憤. I do think there are some areas where it can improve and incentivize contributions from new contributors. Here is my feedback:

  • The README can make use of more markdown features to emphasize important parts. This helps the reader get straight to the info they need and are looking for, for example:

... command line enter:
pip3 install pychromecast <-- Used for voice announcement on Google Home.
pip3 install beautifulsoup4 <-- Used for web scraping for sunrise and sunset times.

  • Use labels to categorize your issues.
    _Note: It's great you're organizing your work with GitHub issues in the 1st place 馃憤_

Hope that helps 馃槂

Great idea, I'm new to documenting my repositories.

Cheers 馃憤馃榿

Looks great @RasPiPkr ! And great feedback @BOLT04 馃憤

@RasPiPkr I will review in a future video / live stream too 馃 - thanks for sharing your repo

That would be great thanks :thumbsup:

The project looks really great @RasPiPkr 馃憤

  • As David said, it's great that you're using issues to organise and document the repository.
    It would be really great, if you could add issue templates and labels: these would help you prioritise issues that are more essential or of specific areas, and might also help contributors in finding an issue that they would like to work on.|

  • To maintain code quality, and make your tasks as a maintainer slightly easier, you could perhaps add a github action to lint and build the project?
    the ones provided by github: https://github.com/RasPiPkr/myHome/actions/new

Great idea, I will look in to it tomorrow.

Thank you for your suggestion.

Reviewing on a live stream https://youtu.be/oM8rBNyiwPY

Looks good, some suggestions:

  • Use Pull Requests to encourage others to contribute
  • Issues to have labels to make it easier for the community to join in
  • Maybe have 1 image at the top of the repo (animated gif going through a few images or a demo would be great)
  • Label example commands as a quickstart guide section
Was this page helpful?
0 / 5 - 0 ratings

Related issues

adityaraute picture adityaraute  路  5Comments

plazzy99 picture plazzy99  路  4Comments

ChoukseyKhushbu picture ChoukseyKhushbu  路  4Comments

Vyvy-vi picture Vyvy-vi  路  4Comments

jamesgeorge007 picture jamesgeorge007  路  4Comments