Support: [Project Review]: This a project me and my friend made for our college submission

Created on 16 Nov 2020 · 13Comments · Source: EddieHubCommunity/support

Items we can review on a live stream:

Open source project

Technologies used:

Django
TailwindCSS
Javascript

Repository: https://github.com/EquipstatTSEC/webstore

Hosted on: https://equipstat.herokuapp.com

You may use dummy details to register on the site.

Because of the limited time, we couldn't make it responsive. But apart from that if you could review it and give me any suggestions/advice it would really mean a lot to me.

open source review

Source

dheerajdlalwani

👍1

Most helpful comment

I love the colour scheme and simplicity. The layout is also very pleasing.

Here is my feedback on possible improvements.

I took my test to the hosted site instead of github. A few things I would question or change. I admit they could subject to location and target market but here goes.

Filling in the registration form requires that I give you my phone number. I'm not comfortable with that and will likely give you a fake one. (yes, I know this was a test.

phone_number_is_mandatory

Some products require that I call the seller or email them, while some have (what I expected) an "add to cart" button.
2b. When you click on "contact" it actually tries to open a call app. Thankfully, I tested on my desktop, so no app opened and I had the chance to cancel that action :)

contact_wants_to_cantact

2c. I moused over the 'contact' to see what it was trying to do and noticed a 'tel:######'
mouseOver_contact

Some allignment on the products page seem a bit off to me.

text_allignment

The home page didn't display well on my phone (yes, I switched to my phone to see what it would look like).

I hope these help.

mikeysan on 16 Nov 2020

👍3

All 13 comments

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] on 16 Nov 2020

Initial feedback...

use Issues
use Pull Requests
use Actions for linting or similar even if there are no automated tests
keep file/folder naming consistent, this one stands out EquipStat_WebStore
README to have quickstart, requirements etc
add Code of Conduct

eddiejaoude on 16 Nov 2020

Sure! I will look into it right away.

dheerajdlalwani on 16 Nov 2020

I love the colour scheme and simplicity. The layout is also very pleasing.

Here is my feedback on possible improvements.

I took my test to the hosted site instead of github. A few things I would question or change. I admit they could subject to location and target market but here goes.

Filling in the registration form requires that I give you my phone number. I'm not comfortable with that and will likely give you a fake one. (yes, I know this was a test.

phone_number_is_mandatory

Some products require that I call the seller or email them, while some have (what I expected) an "add to cart" button.
2b. When you click on "contact" it actually tries to open a call app. Thankfully, I tested on my desktop, so no app opened and I had the chance to cancel that action :)

contact_wants_to_cantact

2c. I moused over the 'contact' to see what it was trying to do and noticed a 'tel:######'
mouseOver_contact

Some allignment on the products page seem a bit off to me.

text_allignment

The home page didn't display well on my phone (yes, I switched to my phone to see what it would look like).

I hope these help.

mikeysan on 16 Nov 2020

👍3

Thank you so much @mikeysan for all these reviews.

Yes there are 2 kinds of products.
- So the ones which have an add to cart feature, are new products which we the owners of the site plan to sell. So they will be transacting with us. (Store page)
- the other type is the refurbished products. So, you as an account holder can enlist the products you wish to sell and we will display them as listings. (Refurbished page) In that case, you have to directly contact the seller and we are just here to present you with the listing.
About the telephone link, we thought it would be a cool feature to like allow the user to call the seller at the click of a button. We took the idea from google maps app which allows you to call directly. Is that like a bad choice? Or something which is un expected or bad design?
Alignment issues and responsiveness we are working on. So thank you for pointing out the issue on Products page.

dheerajdlalwani on 17 Nov 2020

👍1

Hey @dheerajdlalwani I really like this "...the other type is the refurbished products... In that case, you have to directly contact the seller and we are just here to present you with the listing..." idea. Very good idea.

I'm not a product architect by any means, but thinking as a buyer, I wouldn't really want to call someone I don't know about buying a product I saw on a website. The reason it works for Google maps is because you are more likely calling a business to get directions or ask about opening times.

To your question about bad choice or bad design, I would say no. It is NOT a bad design or choice. It is simply a design choice that has to be weighed against a pros and cons list. That list will ultimately also have to rely on your target market. If your tarket market expects to be able to simply click a button and call someone, then I would go in that direction. The only thing I would add is the abilty for those who visit the site from a desktop to see the number and then call.

Another feature you could add is the ability to chat to the seller via the site directly. If user and seller decide to take the conversation off the site, then that's their decision.

What do you think?

mikeysan on 17 Nov 2020

👍1

Yes. The chat feature could be a better idea. Infact I had thought about it but due to limited experience I decided as of now to I'll keep the number.
Can you raise that as an issue?

And yes I will make it such that the user can see the phone number before calling.

dheerajdlalwani on 17 Nov 2020

👍1

Great team work everyone 💪

eddiejaoude on 24 Nov 2020

@dheerajdlalwani I was going to review for a video I am recording but the repo is 404?

eddiejaoude on 30 Dec 2020

I don't know what happened...
Just let me take a look...

dheerajdlalwani on 30 Dec 2020

My other collaborator had made it private... 🤦🏻‍♂️
I've made it public again... Do let me know if it works...
https://github.com/EquipstatTSEC/webstore

dheerajdlalwani on 30 Dec 2020

👍2

Seems to work now. The video is recorded and currently being edited. I will review it in the next video / live stream I do for reviewing open source projects

eddiejaoude on 4 Jan 2021

Reviewed in a live stream https://youtu.be/_JjV9n-G-p0

Looks great, some feedback

Be consistent with the naming convention of the folders
No recent commits
No tags/releases taken yet
Maybe use labels on the issues
PRs only by a bot at the moment
Screenshots are great, but maybe too many images - suggest animated gif or YouTube video
Code of conduct would be great https://github.com/EquipstatTSEC/webstore/community