Support: Issue for review for my Todo App

[max-programming]

Items we can review on a live stream:

• GitHub profile - Max Programming
• Open source project - Max Todos

You can also join the discord community here

Feel free to check out other cool repositories of Eddie Jaoude Community here

[github-actions[bot]]

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[eddiejaoude]

Thanks for submitting @max-programming 👍

[eddiejaoude]

@max-programming looks great 👍 , I reviewed it for a YouTube video, here are my thoughts ...

• is the .vscode folder needed?
• create a release
• screenshot in the README (or animated gif)
• use GitHub Action for the build command in package.json
• Add Code of Conduct
• Add license

[max-programming]

Thank you so much @eddiejaoude. I'll apply changes for all of these. These are very important things I did not know.

What is the purpose or need of adding a LICENSE?

[eddiejaoude]

You are welcome 🤓 - I miss lots of things on my projects, so do not worry, it happens to everyone 🤦‍♂️

[mikeysan]

@max-programming looks great 👍 , I reviewed it for a YouTube video, here are my thoughts ...

* is the `.vscode` folder needed?

* create a release

* screenshot in the README (or animated gif)

* use GitHub Action for the `build` command in `package.json`

* Add Code of Conduct

* Add license

.vscode folder can be added to the .gitignore file. That's what I do with mine so it doesn't get uploaded.

[Vyvy-vi]

What is the purpose or need of adding a LICENSE?

(*this is how I understand it, but I'm sure someone else could explain this better)
Generally adding a license to your project increases usability for other developers.
Unlicensed software might get restrictive licenses later on and that might lead to legal issues...

A LICENSE acts as a RULE-BOOK that governs how other people could use your software.
For example:

• You want your software to be useable by anyone in any form, but you want to firmly reassure that there are no liabilities or warranties that come with the software, but want the users to withhold the same LICENSE. In this case you could use MIT License
• You want a copyleft license(no close sourcing of your code, but use in any form):
  GNU GPLv3 or GPLv2
• You want a super-permisive, no liability, no clause license:
  The Unlicense
• Apache License: similar to GPLv3, but restrictive in copied use of trademarks in the code
  Here's a great resource on LICENSEs: https://choosealicense.com/

Here's what would happen if you don't have a license:
https://choosealicense.com/no-permission/

[max-programming]

@max-programming looks great 👍 , I reviewed it for a YouTube video, here are my thoughts ...

* is the `.vscode` folder needed?

* create a release

* screenshot in the README (or animated gif)

* use GitHub Action for the `build` command in `package.json`

* Add Code of Conduct

* Add license

.vscode folder can be added to the .gitignore file. That's what I do with mine so it doesn't get uploaded.

I upload it for custom settings like formatting the file, etc

[max-programming]

What is the purpose or need of adding a LICENSE?

(*this is how I understand it, but I'm sure someone else could explain this better)
Generally adding a license to your project increases usability for other developers.
Unlicensed software might get restrictive licenses later on and that might lead to legal issues...

A LICENSE acts as a RULE-BOOK that governs how other people could use your software.
For example:

• You want your software to be useable by anyone in any form, but you want to firmly reassure that there are no liabilities or warranties that come with the software, but want the users to withhold the same LICENSE. In this case you could use MIT License
• You want a copyleft license(no close sourcing of your code, but use in any form):
  GNU GPLv3 or GPLv2
• You want a super-permisive, no liability, no clause license:
  The Unlicense
• Apache License: similar to GPLv3, but restrictive in copied use of trademarks in the code
  Here's a great resource on LICENSEs: https://choosealicense.com/

Here's what would happen if you don't have a license:
https://choosealicense.com/no-permission/

Thanks for your kind reply. Adding a license is not a big deal

[Vyvy-vi]

(Also, not having a LICENSE means that editing your code might breach the intellectual property copyright or something, resulting in less contributers)

[eddiejaoude]

Video is live https://www.youtube.com/watch?v=braWUyC77z4&feature=youtu.be

[max-programming]

Thank you so much @eddiejaoude