Support: Project and profile review for YouTube video

Created on 10 Nov 2020  路  10Comments  路  Source: EddieHubCommunity/support

Items we can review on a live stream:

GitHub profile https://github.com/garimasingh128

Open source project : https://gitsetgo.netlify.app
Repository link: https://github.com/garimasingh128/gitsetgo

Portfolio: http://garimasingh.me/

Blog: https://garimasingh.netlify.app

open source review

Most helpful comment

A few thoughts on the OpenSource Project:

  • The design looks great 馃憤
  • Functionality of site is good, though a few fixes needed:
    1- the location symbol would look much rather effective if it uses the default GitHub location/ the generic location icon:
    2- The Organisations section lists the company field rather than the GitHub organisations, one is a part of. (might be confusing for a few people)
  • The repo is well-made and looks amazing(would be nice if you link your repo in the issue as well)
    The output:
    Screenshot 2020-11-19 at 11 49 12 PM
    My fields in profile:
    Screenshot 2020-11-19 at 11 50 01 PM

All 10 comments

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 馃 . Any questions let us know.

Thank you for sharing, I look forward to reviewing 馃憤

A few thoughts on the OpenSource Project:

  • The design looks great 馃憤
  • Functionality of site is good, though a few fixes needed:
    1- the location symbol would look much rather effective if it uses the default GitHub location/ the generic location icon:
    2- The Organisations section lists the company field rather than the GitHub organisations, one is a part of. (might be confusing for a few people)
  • The repo is well-made and looks amazing(would be nice if you link your repo in the issue as well)
    The output:
    Screenshot 2020-11-19 at 11 49 12 PM
    My fields in profile:
    Screenshot 2020-11-19 at 11 50 01 PM

Its great the community getting involved and supporting each other 鉂わ笍

Thank you for sharing this awesome project 馃憤 . I reviewed it for my YouTube video, it looks really good 馃

Some small suggestions:

  • Create releases
  • Add build command from package.json to GitHub Action
  • Move pull_request_template.md to .github folder
  • Commits to follow a standard, for example like Conventional changeling style
  • README is great, but soon it might be worth splitting some of it out into a docs/ folder with links from the README
  • Issue labels are not consistent, some are with capitals, some are with spaces and others with _
  • -

Thanks @eddiejaoude I have corrected most of these now and created issues for the others. Your review and advice means a lot. Thanks.

You are welcome @garimasingh128 . The video is being edited today, so should be out this week (hopefully mid week)

Loved the feedback!

Thank you @garimasingh128

Was this page helpful?
0 / 5 - 0 ratings