Supertest: From 3.x to 4.x, is there a new way to use request() ?

[converge]

if I call my API in this way using Supertest 4.x:

return res.status(401).send()

and try to assert it in this way:

response = await request(app).post('/admin').send( { data_here } )
expect(response.status).toBe(401);

Supertest returns Unauthorized and not status code 401 as I'm expecting.

If I do the same thing using Supertest 3.x , it returns the status code I'm expecting to test it.

Is there a new way to do it on version 4.x ?

[blacksonic]

We used to set the expected status code, like 401, but that no longer returns the response, it throws the error instead.
Seems like a breaking change without documentation.

[Christilut]

Same here, used this in 3.x:

  await request(app)
    .post('/system/invoice/generate')
    .set('content-type', 'application/json')
    .set('Authorization', 'invalidtoken')
    .send()
    .expect(httpStatus.UNAUTHORIZED)

Short migration guide would be nice

[bajtos]

This may be a regression - see https://github.com/visionmedia/superagent/issues/1466

[bonesoul]

same and has been reported yesterday but still no fixes.

[akirilyuk]

Don't you have any tests which cover these cases? I mean there was already something similar:

https://github.com/visionmedia/supertest/issues/534

[SMenigat]

Don't you have any tests which cover these cases? I mean there was already something similar:

534

Feel free to open an PR and add those tests 👍

[gjohnson]

I’ve started adding a few tests, the problem is all the tests use callbacks only, so the regression was overlooked, again (sorry!).

[SMenigat]

Just to be clear, my comment was in @akirilyuk s direction.

[akirilyuk]

@SMenigat should not the person who created the fix also add the tests which verifies the error wont happen again? Also should it not be the maintainers job to have meaningful tests for their own product?

[bonesoul]

+1 with @akirilyuk

[rimiti]

558 merged, I close this issue.

Thank you 🙏