Supertest: Update superagent dependency to v4.1.0

Created on 8 Feb 2019  路  6Comments  路  Source: visionmedia/supertest

I'd like to suggest a version bump to 4.1.0 of superagent.

Version 4.1.0 contains a new feature which allows "Ignoring broken/insecure HTTPS on localhost" through a call to .trustLocalhost() this would be incredibly useful for testing purposes.

picture RobertDiebels

Most helpful comment

@RobertDiebels looking into it. I need to look at what # #534 was all about first.

picture gjohnson on 8 Mar 2019
👍2

All 6 comments

Is anyone could upgrade superagent ? I'm currently busy on others projects, but I can provides some help if needed.

rimiti picture rimiti on 23 Feb 2019

@rimiti I could create a PR but I don't know the ramifications of bumping the superagent version since it's a major release.

Note: It's working locally for me.

RobertDiebels picture RobertDiebels on 24 Feb 2019

You've to try to run the tests to know if there are regressions. ;)

rimiti picture rimiti on 24 Feb 2019

Can someone look at the above merge-request? Would be great to get this in as soon as possible.

RobertDiebels picture RobertDiebels on 27 Feb 2019

@RobertDiebels looking into it. I need to look at what # #534 was all about first.

gjohnson picture gjohnson on 8 Mar 2019
👍2

In master

gjohnson picture gjohnson on 9 Mar 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

lovelydreamer picture lovelydreamer  路  4Comments
hacker0limbo picture hacker0limbo  路  3Comments
mayacr86 picture mayacr86  路  4Comments
EverettQuebral picture EverettQuebral  路  3Comments
UniverseHan picture UniverseHan  路  4Comments