Super-linter: release 3.2.0 seems to ignore user provided lint override files

Created on 3 Jul 2020  路  10Comments  路  Source: github/super-linter

Describe the bug
We have two issues that we must override in our codebase - one in markdown and one in python. I have merged all the ongoing changes to the template files while preserving our two overrides. Super Linter acknowledges the two user provided files and then seems to not actually use them when running the markdown and python lints.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the debug-superlint branch in chia-blockchain - https://github.com/Chia-Network/chia-blockchain/tree/debug-superlint
  2. Cause a push or pull (feel free to fork)
  3. Hit the super-lint action
  4. See Markdown MD024 errors that should be overriden by https://github.com/Chia-Network/chia-blockchain/blob/d1a8a3dc7e3963836d73c3550edcf8a8b313d3cb/.github/linters/.markdown-lint.yml#L26 and python errors that should be overriden by https://github.com/Chia-Network/chia-blockchain/blob/d1a8a3dc7e3963836d73c3550edcf8a8b313d3cb/.github/linters/.python-lint#L246

Expected behavior
.markdown-lint.yml and .python-lint should override the lint errors (as they have in earlier releases.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
You can follow my debugging attempts in this PR: https://github.com/Chia-Network/chia-blockchain/pull/302
A recent run - https://github.com/Chia-Network/chia-blockchain/runs/833154863?check_suite_focus=true#step:4:56

bug

All 10 comments

I can also reproduce this issue with ESLint.

I did the test in version 3.0 and it is ok, in 3.1 it is also with error

its not working for me also when using v3
```

  • name: Super Linter
    uses: docker://github/super-linter:v3
    env:
    VALIDATE_KOTLIN: true
    VALIDATE_YAML: true
    `` i do see it recognize i have yaml linter file: User provided file:[.yaml-lint.yml], setting rules file...`
    but later when linting the yaml files i still see errors which indicate he ignores my updated rules.

to be honest i'm trying for the last few days to get this working on few repositories, with different versions, no luck.

ok this first issue was fixed by setting the variables globally scoped.
it works with master for the yaml issue.

for docker linters it still does not work

Could be fixed by associative array in Bash 4...? This is an annoying little bug...

@leviem1 agree this bug sucks... Any help to resolve is much appreciated, busy week and not a ton of time to hunt :)

I have narrowed this down to being introduced after 3.1.1. This is a successful run for 3.1.1 on the same codebase/branch from above.

@admiralAwkbar That might help. If _I_ get the sword do _I_ get to be king? 馃槅

!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

brunomartinspro picture brunomartinspro  路  4Comments

dshevtsov picture dshevtsov  路  4Comments

bbaassssiiee picture bbaassssiiee  路  5Comments

lechen26 picture lechen26  路  5Comments

dshevtsov picture dshevtsov  路  3Comments