Super-linter: Super-Linter Build step feels slow

Created on 22 Jun 2020  路  7Comments  路  Source: github/super-linter

Hello!

I've eagerly setup Super-Linter and found that it is by far slowest GitHub Action that I run against my PR.

Build github/[email protected] step has taken 4m 27s to complete.

My GitHub Action defined as follows:

---
###########################
###########################
## Linter GitHub Actions ##
###########################
###########################
name: Lint Code Base

#
# Documentation:
# https://help.github.com/en/articles/workflow-syntax-for-github-actions
#

#############################
# Start the job on all push #
#############################
on:
  push:
    branches-ignore:
      - 'master'

###############
# Set the Job #
###############
jobs:
  build:
    # Name the Job
    name: Lint Code Base
    # Set the agent to run on
    runs-on: ubuntu-latest

    ##################
    # Load all steps #
    ##################
    steps:
      ##########################
      # Checkout the code base #
      ##########################
      - name: Checkout Code
        uses: actions/checkout@v2

      ################################
      # Run Linter against code base #
      ################################
      - name: Lint Code Base
        uses: github/[email protected]
        env:
          VALIDATE_ALL_CODEBASE: false
          VALIDATE_YAML: true

Is there anything that I am doing wrong?

Are there any suggestions on how I can make it go faster?

question

Most helpful comment

It's very slow for me too. Takes between 1m 44s and 1m 57s to pull the image.

All 7 comments

Hey there!

Check out the bottom note at: https://github.com/github/super-linter#example-connecting-github-action-workflow, namely:

NOTE: Using the line:uses: docker://github/super-linter:v2.1.0 will pull the image down from DockerHub and run the GitHub Super-Linter. Using the line: uses: github/[email protected] will build and compile the GitHub Super-Linter at build time. This can be far more costly in time...

It's time a while, because you are building the container yourself, instead of using the published image 馃槃

Hey @Hanse00 ,

Thank you for the prompt reply. I've run it with the docker image and it only took 37s. Dramatic improvement. Also 馃憥 to me for not reading README properly

Feels like docker image should be presented as a default option here.

Check out the bottom note at: github/super-linter#example-connecting-github-action-workflow, namely:

NOTE: Using the line:uses: docker://github/super-linter:v2.1.0 will pull the image down from DockerHub and run the GitHub Super-Linter. Using the line: uses: github/[email protected] will build and compile the GitHub Super-Linter at build time. This can be far more costly in time...

It's time a while, because you are building the container yourself, instead of using the published image 馃槃

this note is no longer part of the readme.. is it still a good way to improve performance?
is there a particular reason why it is no longer part of the README?

In https://github.com/github/super-linter/pull/577 it says that it is no longer required to prepend docker:// because it will happen automatically

I see, thanks for your reply.

I got download times of a few minutes, therefore got the impression I am facing the same issue (private repo):
image

but as you say, it seems it was even slower before and what I am facing here is the expected download time.

It's very slow for me too. Takes between 1m 44s and 1m 57s to pull the image.

Same here, very slow.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ymd-h picture ymd-h  路  3Comments

jimsmith picture jimsmith  路  5Comments

MuhaddiMu picture MuhaddiMu  路  3Comments

bbaassssiiee picture bbaassssiiee  路  5Comments

thehesiod picture thehesiod  路  4Comments