Sulu: Preview iframe reappears after returning from permissions tab although preview is loaded in separate window

[eekes]

| Q | A
| --- | ---
| Sulu Version | 2.0.3
| Browser Version | Chrome 79.0.3945.130

Actual Behavior

In the admin, the preview iFrame disappears when clicking "Open in a new window"

Expected Behavior

In https://github.com/sulu/sulu/issues/5019 you mentioned this:

The preview iframe appears again after switching back from the Permissions tab although it is already opened in a separate window

But what I would expect is that the frame is never hidden, no matter if you click "new window" or not. If I would want the preview iframe to be hidden, I'd click a "hide preview" button (which doesn't seem to exist right now 😄)

Steps to Reproduce

When I'm clicking "Open in a new window", the iframe disappears. When clicking through the first 4 tabs (Details, SEO, Excerpt & Taxonomies, Settings) it stays hidden. When I click "Permissions", and then go back to one of the other 4 tabs, the iframe reappears again.

[danrot]

That the iframe is disappearing is actually intentional. What would be the use case for opening it in a new window, and still waste valuable space, which can be taken by the form otherwise?

But what is definitely a bug is that it behaves differently for the permission tab. IMO the iFrame should not appear after returning from it, if the preview is already loaded in a separate window.

[eekes]

@danrot I dunno, without really paying attention to it I regularly just open it in a new window to see how it looks full screen, when I then go back to the admin I have to reload to get the preview back. To me it seems more logical to be able to choose whether you want do display a preview or not, and also have to ability preview it in a new window.

[danrot]

That would mean more clicks, so I don't really see that as an advantage... If you close the tab with only the preview in it, the iframe should appear again as well. Have you known that?

I would say the primary use case is if you have two screens, so that you can open the entire preview on a separate screen. If you consider this use case, what you are suggesting would be a little bit cumbersome.

[eekes]

@danrot oh I didn't know that, I also see the new window also automatically refreshes. In that case, only the permissions tab part is indeed a bug 😄