Sulu: Form mandatory validation triggers on disabled fields

[HadGS]

| Q | A
| --- | ---
| Bug? | yes
| New Feature? | no
| Sulu Version | sulu-2.0

Actual Behavior

Form validation triggers on mandatory disabled fields, which prevents form from being saved.

Expected Behavior

Form validation doesn't insist on fill disabled mandatory fields.

Steps to Reproduce

<property name="relative" type="checkbox">
</property>
<property name="url" type="url" mandatory="true" visibleCondition="relative != true" disabledCondition="relative == true">
</property>
<property name="relativeUrl" type="text_line" mandatory="true" visibleCondition="relative == true" disabledCondition="relative != true">
</property>

Possible Solutions

Either form validation should skips disabled fields, or mandatory field should be conditionable like disabledCondition (which will give more freedom to use forms).

[sanhofman]

Will this be available any time soon?

Or is there currently another way to achieve conditionable mandatory validation?

[antonstsk]

It's related to this issue in way #5312

[alexander-schranz]

The validation is handled in the frontend, so its not related to #5312.

I can currently not say when this is been fixed, as it would need first some concept.
Currently out of the form metadata a JSON Schema is generated which is validated in the frontend before submitting the form. At the current state the generated schema does not consider disableConditions or visibleConditions. At the end I think we need to generate then something like the conditional schemas here: https://json-schema.org/understanding-json-schema/reference/conditionals.html if visible or disable condition is set. I think the heavy part will be converting jexl (which we use in for conditions) into this json schema conditions.

[timkoopmans50]

A fix for this would be much appreciated, without it we are very limited if complex conditional forms are required.

[alexandersch]

Is there a way we could help with this maybe?

[danrot]

I think the main problem here is that we evaluate all the conditions you can pass to via XML (disabledCondition, visibleCondition, ...) too early in the frontend. We probably have to postpone that jexl evaluation, in order to react on things like this properly. This is also the main reason for #5291...

I think I am going to have a look at this after I finished #5608. I don't think you can really help out here, unless you get chin-deep into the code :see_no_evil: